Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add title attribute to Donation Form block iframes #7691

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jan 24, 2025

Resolves:
Accessibility Audit: Give-041
https://lw.slack.com/archives/C0355E6LBMZ/p1736794600442929

Description

The Donation Form block iframes currently lacks a descriptive title attribute and are auto-set to title="iframe"

To improve accessibility, I’ve added a descriptive title attribute to the iframe-resizer components used in the Donation Form blocks. This change ensures that each iframe used for block previews and different display types is properly labeled, enhancing the user experience for those relying on assistive technologies.

Additionally, reorganized the import statements on the files changed.

Affects

  • Donation Form block.
  • W/ different display types selected. (Modal, Reveal, etc..)
  • Both frontend and admin screen.

Visuals

Testing Instructions

  • Create a form.
  • Create a page with Donation Form blocks using each display type.
  • View the iframes in the console and verify that the title attribute has been updated to "Donation Form".
  • Repeat last step in the admin block editor and the frontend webpage.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review January 24, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants