Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add aria-label to custom amount field #7692

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: add aria-label to custom amount field #7692

wants to merge 2 commits into from

Conversation

JoshuaHungDinh
Copy link
Contributor

@JoshuaHungDinh JoshuaHungDinh commented Jan 24, 2025 •
edited
Loading

Resolves:
Accessibility Audit: Give-033
https://lw.slack.com/archives/C0355E6LBMZ/p1736794600442929

Description

This update includes an aria-label for the custom amount field, as it lacks a corresponding <label> element for assistive technologies.

Affects

  • Custom Amount field on Donation Forms.

Visuals

Testing Instructions

  • View a form.
  • Check the console and verify that the custom amount field is properly labeled with an aria-label attribute.

Pre-review Checklist

  • Acceptance criteria satisfied and marked in related issue
  • Self Review of code and UX completed

@JoshuaHungDinh JoshuaHungDinh marked this pull request as ready for review January 24, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaHungDinh @jonwaldstein