-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update p4python version to latest #221
Conversation
I believe the Travis CI failure is related to python 3.9 being incompatible with p4python. |
Do we need to upgrade to python 3.9, or can we keep p4python using its own virtual environment? |
I believe we need to use another version of python for our macos test agent |
The error is almost certainly unrelated to your changes. This issue was observed in the past, changing docs files. edit: @DoomGerbil , do you have any objection to @improbable-mattchurch having his merge pushed through on this? |
If this is the case, then we should switch off the mac job so it doesn't keep failing. That said, from a quick glance at the logs, I think @improbable-mattchurch is right about the 3.9.0 version being the problem. p4python only actually claims compatibility with Python 2.6, 2.7, 3.3, and 3.4, and we're using none of those. So basically yep, I can override the red tests and then disable the mac pipeline on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah ha, then again, #213 exists. I'll see if this fixes things first, and if it does, I'll do that. Otherwise, I'll switch off osx builds for the meantime. |
#222 is now open to disable the osx build for now. |
No description provided.