Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update p4python version to latest #221

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Conversation

improbable-mattchurch
Copy link
Contributor

No description provided.

@improbable-mattchurch
Copy link
Contributor Author

I believe the Travis CI failure is related to python 3.9 being incompatible with p4python.

@LeadTimeNull
Copy link
Contributor

Do we need to upgrade to python 3.9, or can we keep p4python using its own virtual environment?

@improbable-mattchurch
Copy link
Contributor Author

I believe we need to use another version of python for our macos test agent

@LeadTimeNull
Copy link
Contributor

LeadTimeNull commented Feb 18, 2021

The error is almost certainly unrelated to your changes. This issue was observed in the past, changing docs files.
@jared-improbable discussed it with @petemounce and IIRC it was decided that we don't wish to go through the trouble of supporting the MacOS pipeline.
@petemounce is out sick today, perhaps @DoomGerbil will be able to weigh in?

edit: @DoomGerbil , do you have any objection to @improbable-mattchurch having his merge pushed through on this?

@DoomGerbil
Copy link

DoomGerbil commented Feb 18, 2021

IIRC it was decided that we don't wish to go through the trouble of supporting the MacOS pipeline.

If this is the case, then we should switch off the mac job so it doesn't keep failing. That said, from a quick glance at the logs, I think @improbable-mattchurch is right about the 3.9.0 version being the problem. p4python only actually claims compatibility with Python 2.6, 2.7, 3.3, and 3.4, and we're using none of those.

So basically yep, I can override the red tests and then disable the mac pipeline on master post-facto.

Copy link

@DoomGerbil DoomGerbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DoomGerbil DoomGerbil merged commit 3c476d3 into master Feb 18, 2021
@DoomGerbil DoomGerbil deleted the improbable-mattchurch-patch-1 branch February 18, 2021 15:45
@DoomGerbil
Copy link

Ah ha, then again, #213 exists. I'll see if this fixes things first, and if it does, I'll do that.

Otherwise, I'll switch off osx builds for the meantime.

@DoomGerbil
Copy link

#222 is now open to disable the osx build for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants