Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FlexIO definitions and 1060 pad config #37

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

Finomnis
Copy link
Contributor

No description provided.

@Florob
Copy link
Contributor

Florob commented Jun 13, 2023

I had started on something similar for 1020, but put it on hold due to imxrt-rs/imxrt-ral#32.
Have you already written a consumer for the flexio::Pin trait? My hunch is that having const OFFSET: u32 rather than type Pin: consts::Unsigned is easier to work with. It also has precedence in gpio::Pin.

@Finomnis
Copy link
Contributor Author

Have you already written a consumer for the flexio::Pin trait?

Will give it a try within the next days.

@Finomnis
Copy link
Contributor Author

@Florob I didn't get to writing a consumer yet, but in theory I agree, so I changed it.

Is this what you had in mind?

@Florob
Copy link
Contributor

Florob commented Jun 14, 2023

Is this what you had in mind?

Actually not. I was talking about the Pin associated type, not the generic.
I'd try to align with the gpio::Pin trait here, which has the generic as consts::Unsigned, and then an OFFSET: u32 associated constant.

@Finomnis
Copy link
Contributor Author

Actually not. I was talking about the Pin associated type, not the generic. I'd try to align with the gpio::Pin trait here, which has the generic as consts::Unsigned, and then an OFFSET: u32 associated constant.

I'm uncertain what you mean. imxrt_iomux::gpio::Pin has a const N: u8 generic.

I adjusted it a little, is it better now?

@Finomnis
Copy link
Contributor Author

@Florob I'm not far yet, so far I only print the parameters, but this is the driver I'm working on: https://github.com/Finomnis/ws2812-flexio
Just for information.

@Florob
Copy link
Contributor

Florob commented Jun 15, 2023

I'm uncertain what you mean. imxrt_iomux::gpio::Pin has a const N: u8 generic.

I'm so sorry. I must somehow have been looking at an ancient revision. What you have now is indeed what I would have suggested.

I'm not far yet, so far I only print the parameters, but this is the driver I'm working on: https://github.com/Finomnis/ws2812-flexio

That link 404s for me. Is the repository set to private perhaps?

@Finomnis
Copy link
Contributor Author

@Florob Oops. Fixed. Apologies.

Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing the interface. I'll release in v0.2.

@mciantyre mciantyre merged commit 3a57656 into imxrt-rs:master Jul 3, 2023
4 checks passed
@Finomnis Finomnis deleted the flexio branch July 3, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants