New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equate fieldset names #33

Merged

mciantyre merged 4 commits into master from equate-fieldset-names

Jul 3, 2023

Merged

Equate fieldset names #33

Re-generate remainder of the RAL

This check has been archived and is scheduled for deletion. Learn more about checks retention

GitHub Actions / clippy succeeded Jul 3, 2023 in 1s

clippy

6 warnings

Details

Results

Message level	Amount
Internal compiler error	0
Error	0
Warning	6
Note	0
Help	0

Versions

rustc 1.70.0 (90c541806 2023-05-31)
cargo 1.70.0 (ec8a8a0ca 2023-04-25)
clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check warning on line 26 in raltool/src/transform/rename.rs

github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:26:48
   |
26 |         super::map_device_peripheral_names(ir, &renamer);
   |                                                ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 25 in raltool/src/transform/rename.rs

github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:25:35
   |
25 |         super::map_enum_names(ir, &renamer);
   |                                   ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 24 in raltool/src/transform/rename.rs

github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:24:39
   |
24 |         super::map_fieldset_names(ir, &renamer);
   |                                       ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 23 in raltool/src/transform/rename.rs

github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:23:36
   |
23 |         super::map_block_names(ir, &renamer);
   |                                    ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 22 in raltool/src/transform/rename.rs

github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:22:37
   |
22 |         super::map_device_names(ir, &renamer);
   |                                     ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 75 in raltool/src/generate/device.rs

github-actions / clippy

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
  --> raltool/src/generate/device.rs:75:37
   |
75 |             let address = util::hex(peripheral.base_address as u64);
   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `peripheral.base_address`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

View more details on GitHub Actions