Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NVIC, SCB from the 1176 #50

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mciantyre
Copy link
Member

@mciantyre mciantyre commented Sep 9, 2024

#49 observed that the 1176 modules export register blocks for the Cortex-M NVIC. The 1176 also exports the SCB. This is inconsistent with #17, so this PR removes the NVIC and SCB peripherals from the 1176.

As a side effect, this marks the 1176 GPU2D interrupt as reserved. See the commit message for more information.

The 1176 imxrt-ral modules no longer provide an API for the NVIC or SCB.
It's the same process as b1fee46, but applied to the 1176 modules. I
re-introduced core interrupts by attaching them to the miscellaneous
control module (MCM). All separate GPC peripheral blocks are logically
within a single 'GPC' space, so selecting the standby sub-module was an
arbitrary decision.

Notice that this commit marks the GPU2D interrupt as reserved. This is
intentional; the SVDs do not describe a GPU2D peripheral, so imxrt-ral
doesn't have a corresponding module. This interrupt probably
piggy-packed on the NVIC. We can re-introduce that interrupt when we
describe the GPU2D peripheral.
Copy link
Member

@teburd teburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a fan of massive line reduction PRs

@mciantyre mciantyre merged commit 95289cf into imxrt-rs:master Sep 16, 2024
29 of 40 checks passed
@mciantyre mciantyre deleted the remove-1176-nvic-scb branch September 16, 2024 10:06
@mciantyre mciantyre mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants