Skip to content

Re-generate peripherals with enum name checks #226

Re-generate peripherals with enum name checks

Re-generate peripherals with enum name checks #226

GitHub Actions / clippy succeeded Apr 26, 2024 in 0s

clippy

9 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 9
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check warning on line 26 in raltool/src/transform/rename.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:26:48
   |
26 |         super::map_device_peripheral_names(ir, &renamer);
   |                                                ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 25 in raltool/src/transform/rename.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:25:35
   |
25 |         super::map_enum_names(ir, &renamer);
   |                                   ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 24 in raltool/src/transform/rename.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:24:39
   |
24 |         super::map_fieldset_names(ir, &renamer);
   |                                       ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 23 in raltool/src/transform/rename.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:23:36
   |
23 |         super::map_block_names(ir, &renamer);
   |                                    ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 22 in raltool/src/transform/rename.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> raltool/src/transform/rename.rs:22:37
   |
22 |         super::map_device_names(ir, &renamer);
   |                                     ^^^^^^^^ help: change this to: `renamer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
   = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 301 in raltool/src/svd2ir.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you seem to use `.enumerate()` and immediately discard the index

warning: you seem to use `.enumerate()` and immediately discard the index
   --> raltool/src/svd2ir.rs:301:25
    |
301 |         for (_n, &i) in irqs.iter().enumerate() {
    |                         ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index
    = note: `#[warn(clippy::unused_enumerate_index)]` on by default
help: remove the `.enumerate()` call
    |
301 |         for &i in irqs.iter() {
    |             ~~    ~~~~~~~~~~~

Check warning on line 49 in raltool/src/generate/fieldset.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `unwrap_or_else` to construct default value

warning: use of `unwrap_or_else` to construct default value
  --> raltool/src/generate/fieldset.rs:49:18
   |
49 |                 .unwrap_or_else(TokenStream::new)
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
   = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 75 in raltool/src/generate/device.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
  --> raltool/src/generate/device.rs:75:37
   |
75 |             let address = util::hex(peripheral.base_address as u64);
   |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `peripheral.base_address`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 365 in raltool/src/combine.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-canonical implementation of `clone` on a `Copy` type

warning: non-canonical implementation of `clone` on a `Copy` type
   --> raltool/src/combine.rs:363:29
    |
363 |       fn clone(&self) -> Self {
    |  _____________________________^
364 | |         Self(self.0)
365 | |     }
    | |_____^ help: change this to: `{ *self }`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl
    = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default