Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that the
ResultStatement::fetchColumn()
function returns either astring
or aboolean
but the return value is compared with=== 0
in the code which requires the variable to be aninteger
(as0 == '0'
evaluates totrue
but0 === '0'
evaluates tofalse
in PHP). Therefore i suggest casting the$count
variable fromstring
toint
. Otherwise it is impossible to create a new backend user on the client TYPO3 instance because the SQLINSERT
statement is never executed. In order to reproduce this issue simply delete the backend user on the client TYPO3 instance and try to log in as that user once again. The T3AM authentication will not work because the backend user is not inserted into thebe_users
table. I referenced the relevant code line below.t3am/Classes/UserRepository.php
Line 277 in 6e5e799