Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crear/merge kb cleanup #55

Closed
wants to merge 25 commits into from
Closed

Crear/merge kb cleanup #55

wants to merge 25 commits into from

Commits on Apr 1, 2013

  1. Adding drag options to ko/kb UniverseViewList Fix #39 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    7586378 View commit details
    Browse the repository at this point in the history

  2. tell template whether we are showing a PlayList or a MediaList 

    also, restore the "connectable" class to the table, without it
drag behaves funny.

Signed-off-by: Adrian Pardini <[email protected]>
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    917ac23 View commit details
    Browse the repository at this point in the history

  3. Do not show 'close (x)' button for MediaLists 

    Previously you close the MediaList panel while editing playlists
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    faedeb4 View commit details
    Browse the repository at this point in the history

  4. Adding playlists insensitve search - Fixes #45 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    8d1957b View commit details
    Browse the repository at this point in the history

  5. Insensitve search for Medialist - Fixes #48 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    732544e View commit details
    Browse the repository at this point in the history

  6. Add border-spacing to 5px, So I can drop elements easily. #35 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    a109763 View commit details
    Browse the repository at this point in the history

  7. Adding dragOptions to media list drag elements: cursor position 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    5748bf6 View commit details
    Browse the repository at this point in the history

  8. Adds a delete button to playlist editor. 

    See #36 y #37. It needs a better look.
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    2c6a226 View commit details
    Browse the repository at this point in the history

  9. Adding title on top media details #34 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    0a10e23 View commit details
    Browse the repository at this point in the history

  10. Deleting titles #40 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    8944fd8 View commit details
    Browse the repository at this point in the history

  11. correct container for search form 

    Before this it wouldn't show on the view.

Signed-off-by: Adrian Pardini <[email protected]>
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    7bf728d View commit details
    Browse the repository at this point in the history

  12. Universe: update time automagically. 

    Adds a dummy dependency to the collection so it updates whenever something changes in it.

Closes #41
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    5efb577 View commit details
    Browse the repository at this point in the history

  13. hide alert boxes after switching playlists 

    Fixes #42
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    952af5d View commit details
    Browse the repository at this point in the history

  14. medialist: remove unnecessary class from template

    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    64bf952 View commit details
    Browse the repository at this point in the history

  15. medialist: remove all the is_playlist / sortable nonsense 

    I've kept disable_drag just for Browse Medias
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    00763cf View commit details
    Browse the repository at this point in the history

  16. document KB dependency injection for total_time 

    When we access other Observables within a ComputedObservable
KO keeps track of that and updates the ComputedObservable accordingly.
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    ed6b96a View commit details
    Browse the repository at this point in the history

  17. show total time for playlists. 

    Also, remove the total time bar for Browse Media / Left panel.
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    361d513 View commit details
    Browse the repository at this point in the history

  18. remove total time bar from Universe view

    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    f680eb1 View commit details
    Browse the repository at this point in the history

  19. Adding old title #40 as tooltip on schedule 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    f1d0d50 View commit details
    Browse the repository at this point in the history

  20. adds a 'type' option to MediaListView 

    See discussion at e080b8e

Now we have four types of MediaListView:
  - playlist-sortable (like the current playlist on Edit Playlists)
    has full drag and drop, can edit name and remove elements
  - playlist-draggable (like the left pane on Edit Playlists)
    cannot edit name nor remove elemens, dragging is enabled
  - playlist-searchable (like the one on Browse Medias)

As a side effect the duration bar was restored.
    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    7d7449c View commit details
    Browse the repository at this point in the history

  21. Adding trash support to remove from playslist #37 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    c0b0cbc View commit details
    Browse the repository at this point in the history

  22. Cleaning up old backbone views code 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    85786ac View commit details
    Browse the repository at this point in the history

  23. Cleaning up Comments in UniItemView 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx @pardo-bsso
    josx authored and pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    bc32569 View commit details
    Browse the repository at this point in the history

  24. Refactoring SearchView 

    Signed-off-by: José Luis Di Biase <[email protected]>
    @josx
    josx committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    dff528c View commit details
    Browse the repository at this point in the history

  25. UniverseListView: add custom click handler

    @pardo-bsso
    pardo-bsso committed Apr 1, 2013
    Configuration menu
    Copy the full SHA
    f4b258c View commit details
    Browse the repository at this point in the history