-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICD / Docker image #426
CICD / Docker image #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand enough about Docker to provide constructive criticism here, but just so I understand what's happening, the Github workflows just push new images to Docker Hub? They don't actually deploy those images onto any of our machines?
Indeed @kueda, the last step of the workflow is pushing docker images to the docker registry. The deployment of these images on the kubernetes cluster will be handled in a separated workflow, for security reasons. The fact that our github is public requires to be really cautious. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I requested a couple changes in config.docker.js
but otherwise this looks good to me
Create a new config file (config.docker.js) using ENV variables (injected by docker compose or kubernetes manifest)
Rework the gitlab CI files to have 3 workflows: