Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD / Docker image #426

Merged
merged 29 commits into from
Mar 5, 2024
Merged

CICD / Docker image #426

merged 29 commits into from
Mar 5, 2024

Conversation

sylvain-morin
Copy link
Contributor

Create a new config file (config.docker.js) using ENV variables (injected by docker compose or kubernetes manifest)

Rework the gitlab CI files to have 3 workflows:

  • main: build the main branch and push 2 docker images, tagged "latest" and using the git commit ID
  • dev: build any dev branch and push a docker image, tagged using the (sanitized) branch name
  • pr: build any PR, running only the test (no docker image creation/push)

Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand enough about Docker to provide constructive criticism here, but just so I understand what's happening, the Github workflows just push new images to Docker Hub? They don't actually deploy those images onto any of our machines?

@sylvain-morin
Copy link
Contributor Author

Indeed @kueda, the last step of the workflow is pushing docker images to the docker registry.

The deployment of these images on the kubernetes cluster will be handled in a separated workflow, for security reasons. The fact that our github is public requires to be really cautious.

Copy link
Member

@pleary pleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested a couple changes in config.docker.js but otherwise this looks good to me

config.docker.js Show resolved Hide resolved
.github/workflows/CICD-pr.yml Show resolved Hide resolved
config.docker.js Outdated Show resolved Hide resolved
@sylvain-morin sylvain-morin merged commit 3bc724c into main Mar 5, 2024
6 checks passed
@sylvain-morin sylvain-morin deleted the k8s branch March 5, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants