feat: support basic layout, typography, and photo carousel in RTL #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a wrapper around Text for all typography components that sets app-specific defaults * Set one of those defaults to be left-aligned text so RN / iOS can reverse it for RTL languages
Also setups up this file for automated Crowdin sync, but that doesn't entire work yet.
Removes react-native-reanimated-carousel, which needs to be patched to support RTL and maybe wasn't providing anything beyond FlatList for us anyway.
kueda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: while this does globalize Info.plist strings and sets up Crowdin syncing in a way that should work, crowdin CLI downloads with our configuration will not work until crowdin/crowdin-cli#486 is addressed, so until then we'll need to manually update ios/InfoPlist.xcstrings
Partial work toward #2099