Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for alien species portal v1.1.0 #253

Open
mvarewyck opened this issue Sep 27, 2024 · 4 comments
Open

Update translations for alien species portal v1.1.0 #253

mvarewyck opened this issue Sep 27, 2024 · 4 comments
Assignees

Comments

@mvarewyck
Copy link
Collaborator

Some translations are missing here

@mvarewyck
Copy link
Collaborator Author

I also get missing translations for following regions: Buetgenbach, Ouderghem
If no translation needed, no action needed. If you want to include a translation for these, please add them to translations_regions.csv
(They might be already in the translations for another id, but then not same id is used in all datasets)

@SanderDevisscher
Copy link
Collaborator

SanderDevisscher commented Oct 14, 2024

Both Buetgenbach & Ouderghem are in translation_region with another id (resp. Bütgenbach & Oudergem)

@mvarewyck can you indicate in which datasets Buetgenbach & Ouderghem occur ?

@soriadelva I think it is a good idea to expand the translation check to every dataflow.

SanderDevisscher added a commit that referenced this issue Oct 14, 2024
SanderDevisscher added a commit that referenced this issue Oct 14, 2024
SanderDevisscher added a commit that referenced this issue Oct 14, 2024
SanderDevisscher added a commit that referenced this issue Oct 14, 2024
SanderDevisscher added a commit that referenced this issue Oct 17, 2024
SanderDevisscher added a commit that referenced this issue Oct 17, 2024
SanderDevisscher added a commit that referenced this issue Oct 21, 2024
@mvarewyck
Copy link
Collaborator Author

@mvarewyck can you indicate in which datasets Buetgenbach & Ouderghem occur ?

These are in the occurrence data be_alientaxa_cube.csv, column NAAM

@SanderDevisscher
Copy link
Collaborator

@mvarewyck can you indicate in which datasets Buetgenbach & Ouderghem occur ?

These are in the occurrence data be_alientaxa_cube.csv, column NAAM

Ok, I'm currently reworking the be_alien_cube flow, see #18. I'll fix this is issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants