Notify samplingDesign of second dataset is ignored when merging #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sannegovaert
commented
Dec 18, 2024
sannegovaert
commented
- fix Notify samplingDesign of second dataset is ignored when merging #141
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 26 26
Lines 1149 1160 +11
=======================================
+ Hits 1148 1159 +11
Misses 1 1 ☔ View full report in Codecov by Sentry. |
It is important for users to know this. A warning appears _after_ the print (and easier to notice), while a message appears _before_ the print
peterdesmet
approved these changes
Dec 19, 2024
peterdesmet
force-pushed
the
alert_samplingdesign
branch
from
f778cf8 to
c4b4126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.