GitHub source - Do not error on empty repository #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paprikati
reviewed
Jun 23, 2024
| if err == nil { | ||
| return false | ||
| } | ||
| return strings.Contains(err.Error(), "409 Git Repository is empty") |
There was a problem hiding this comment.
I kinda wish we could do something less string-y, but happy with this for now!
paprikati
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Catalog Importer's GitHub "Source" is able to read from all repositories of an organisation, searching each repo's tree for files matching specified file path patterns.
If a repository contains no matching files, no error is thrown. If a repository is empty, it makes sense for the same optimistic behaviour to be followed.
Though GitHub's
Responsetype embeds the HTTP Response, we can't rely on the 409 alone (The API docs describe 409 broadly as "conflict"), so I've opted to string matchIssue #68