Support custom scheme for QR codes #1
+20
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If people have many variants of the same app (say a development build, an rc build, and production) then the default scheme that Expo adds to each app for handling QR previews will be the same: exp+<slug>:// This means whichever app was installed last is the one that will be loaded by QR previews, which often isn't what you want. This commit adds support for providing a custom `scheme` to the continuous delivery action that modifies the slug used in the QR code so users can have them open in the correct app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If people have many variants of the same app (say a development build, an rc build, and production) then the default scheme that Expo adds to each app for handling QR previews will be the same:
exp+<slug>://This means whichever app was installed last is the one that will be loaded by QR previews, which often isn't what you want. This commit adds support for providing a custom
schemeto the continuous delivery action that modifies the slug used in the QR code so users can have them open in the correct app.Linked issue
Provide the issue(s) which this pull request relates to or fixes.
Additional context
Are there things the maintainers should be aware of before merging or closing this pull request?