Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.12 Build Issues #139

Open
skriptble opened this issue Oct 2, 2017 · 3 comments
Open

v2.12 Build Issues #139

skriptble opened this issue Oct 2, 2017 · 3 comments

Comments

@skriptble
Copy link

Hello, I noticed that a new tag for the v2 branch was created (v2.12), but it was tagged from the master branch not the v2 branch. This has brought in roughly 2 years worth of commits. Was this tag made accidentally?
@stgraber
Copy link

stgraber commented Oct 2, 2017

Same question here, I just noticed that the v2 branch (which we use through gopkg.in) got a breaking API change, causing build failures on the LXD codebase.

# github.com/lxc/lxd/shared/logging
shared/logging/log_posix.go:16: not enough arguments in call to log15.Must.SyslogHandler
	have (string, log15.Format)
	want (syslog.Priority, string, log15.Format)
shared/logging/log_posix.go:20: not enough arguments in call to log15.Must.SyslogHandler
	have (string, log15.Format)
	want (syslog.Priority, string, log15.Format)

@stgraber stgraber mentioned this issue Oct 2, 2017
Merged
stgraber added a commit to canonical/lxd that referenced this issue Oct 3, 2017
@stgraber
Temporary workaround for log15 API breakage
7c88b00 
log15 broke their v2 API earlier today, this change should get things
building again until upstream log15 fixes the API breakage.

Related: inconshreveable/log15#139

Signed-off-by: Stéphane Graber <[email protected]>
@stgraber
Copy link

stgraber commented Nov 3, 2017

@inconshreveable any chance you can fix this?

@kylechadha
Copy link

kylechadha commented Nov 7, 2017 •
edited
Loading

👍 +1

We had a breaking build due to the missing stack package:

package gopkg.in/inconshreveable/log15.v2/stack: cannot find package "gopkg.in/inconshreveable/log15.v2/stack" in any of:

@gibmat gibmat mentioned this issue Dec 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skriptble @stgraber @kylechadha