w3c feedbacks

Ref: https://www.notion.so/accelerateur-transition-ecologique-ademe/ACCESSIBILIT-CARTE-FORMULAIRE-Erreurs-dans-le-code-en-W3C-corriger-ef216f7bfed7445181aa55d04220cb46?pvs=4
incubateur-ademe · Aug 22, 2024 · b3aff83 · b3aff83
1 parent acd0227
commit b3aff83
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 11 deletions.
diff --git a/jinja2/layout/base.html b/jinja2/layout/base.html
@@ -40,7 +40,7 @@
                 {% include "layout/header.html" %}
             {% endblock %}
         {% endif %}
-        <main role="main" id="solutions">
+        <main id="solutions">
             <noscript>
                 <div class="fr-container fr-my-3w">
                     <div class="fr-alert fr-alert--error">

diff --git a/jinja2/layout/header.html b/jinja2/layout/header.html
@@ -1,4 +1,4 @@
-<header role="banner" class="fr-header">
+<header class="fr-header">
     <div class="fr-header__body">
         <div class="fr-container">
             <div class="fr-header__body-row">

diff --git a/jinja2/qfdmo/_addresses_partials/filters/_labels_filters.html b/jinja2/qfdmo/_addresses_partials/filters/_labels_filters.html
@@ -1,4 +1,4 @@
-<fieldset class="fr-fieldset qfdmo-gap-y-2w" aria-labelledby="labels-filters-lenged">
+<fieldset class="fr-fieldset qfdmo-gap-y-2w" aria-labelledby="labels-filters-legend">
     <legend class="qfdmo-hidden" id="labels-filters-legend">
         Choisir le(s) filtre(s)
     </legend>

diff --git a/jinja2/qfdmo/_addresses_partials/iframe_form.html b/jinja2/qfdmo/_addresses_partials/iframe_form.html
@@ -36,7 +36,7 @@ <h1 class="qfdmo-hidden">Longue vie aux objets</h1>
                         {% include "qfdmo/partials/action_list_by_direction.html" %}
                     {% endwith %}
                     {% with action_direction='jecherche' %}
-                        {% include "qfdmo/partials/action_list_by_direction.html"  %}
+                        {% include "qfdmo/partials/action_list_by_direction.html" %}
                     {% endwith %}
                 </div>
 

diff --git a/jinja2/qfdmo/_addresses_partials/map_and_detail.html b/jinja2/qfdmo/_addresses_partials/map_and_detail.html
@@ -88,12 +88,12 @@ <h2 class="fr-h4 fr-mt-3w">
                             data-search-solution-form-target="addressMissing"
                         >
                             <picture>
-                                <source srcset="{{ static("map-background-mobile.png")}}" media="(orientation: portrait)" />
+                                <source srcset="{{ static("map-background-mobile.png")}}" media="(orientation: portrait)">
                                 <img
                                     class="qfdmo-absolute qfdmo-left-0 qfdmo-right-0 qfdmo-top-0 qfdmo-bottom-0 qfdmo-w-full qfdmo-h-full qfdmo-object-cover"
                                     src="{{ static("map-background-desktop.png")}}"
                                     alt=""
-                                />
+                                >
                             </picture>
                             <div class="mx-auto qfdmo-max-w-3xl qfdmo-flex qfdmo-flex-col qfdmo-justify-center qfdmo-text-center qfdmo-items-center qfdmo-relative qfdmo-p-1w">
                                 <h3 class="qfdmo-text-2xl sm:qfdmo-text-4xl qfdmo-text-center text-black qfdmo-mb-2w">

diff --git a/jinja2/qfdmo/partials/action_list_by_direction.html b/jinja2/qfdmo/partials/action_list_by_direction.html
@@ -1,6 +1,6 @@
 <div id="{{action_direction}}_fieldset" data-search-solution-form-target='{{action_direction}}'>
     <fieldset class="fr-fieldset fr-mx-0 fr-p-0 fr-mb-1w sm:qfdmo-max-w-[600px]" aria-labelledby="action-by-direction-legend">
-        <legend class="fr-px-0" id="action-by-direction-legend">Je souhaite :</legend>
+        <legend class="fr-px-0" id="action-by-direction-legend-{{ action_direction }}">Je souhaite :</legend>
         {% for action in action_by_direction(request, action_direction) %}
             <div class="fr-fieldset__element fr-my-1v">
                 <div
@@ -16,7 +16,6 @@
                         {% endif %}
                         id="{{action_direction}}_{{action.code}}"
                         type="checkbox"
-                        aria-describedby="{{action.code}}-messages"
                         {% if action.active %} checked{% endif %}
                         >
                         <label class="fr-label before:qfdmo-bg-white fr-text--sm fr-mb-0" for="{{action_direction}}_{{action.code}}">

diff --git a/templates/django/forms/widgets/autocomplete.html b/templates/django/forms/widgets/autocomplete.html
@@ -17,7 +17,6 @@
         "
         data-{{ widget.data_controller }}-target="input"
         data-on-focus=true
-        autocomplete="off"
         type="{{ widget.type }}"
         name="{{ widget.name }}"
         id="{{ widget.attrs.id }}"

diff --git a/templates/django/forms/widgets/autocomplete_and_search.html b/templates/django/forms/widgets/autocomplete_and_search.html
@@ -12,7 +12,6 @@
     "
     data-{{ widget.data_controller }}-target="input"
     data-on-focus=true
-    autocomplete="off"
     type="{{ widget.type }}"
     name="{{ widget.name }}"
     id="{{ widget.name }}"

diff --git a/templates/django/forms/widgets/segmented_control_option.html b/templates/django/forms/widgets/segmented_control_option.html
@@ -5,6 +5,6 @@
         id="{{ widget.value }}" name="{{ widget.name }}"
         {% include "django/forms/widgets/attrs.html" %}>
     <label class="fr-label qfdmo-justify-center" for="{{ widget.value }}">
-        <div>{{ widget.label }}</div>
+        <span>{{ widget.label }}</span>
     </label>
 </div>