Lever une exception si l'identifiant_unique n'est pas unique #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolok
requested review from
fabienheureux and
maxcorbeau
and removed request for
a team
maxcorbeau
requested changes
Dec 9, 2024
| @@ -49,6 +49,20 @@ def apply_corrections_acteur(**kwargs): | |||
| lambda x: shortuuid.uuid(name=x) | |||
| ) | |||
|
|
|||
| # failed is identifiant unique is not unique in the dataframe df_acteur_merged | |||
| if not df_acteur_merged["identifiant_unique"].is_unique: | |||
There was a problem hiding this comment.
Tu fais 2 fois le travail:
- d'abord avec
is_unique(propriété qui engendre un traitement de la df) - puis avec
df_duplicates = ... .duplicated(keep=False)qui refait le taf sur la df
Tu pourrais faire 1 fois avec:
df_duplicates = ... .duplicated(keep=False)if not df_duplicates.empty:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Carte Notion : Titre de la carte
Description plus détaillée de l'intention, l'approche ou de l'implémentation (ce qui n’est pas visible directement en lisant le code)
Type de changement :
Auto-review
Les trucs à faire avant de demander une review :
.env.templateComment tester
En local / staging :