IWF-137: Update iwf-idl to latest to allow separate persistence loading policy for state API #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel27m
requested review from
stevo89519,
longquanzheng,
mixydubs and
lwolczynski
iwf/state_options.go
Outdated
Comment on lines
8
to
12
| WaitUntilApiSearchAttributesLoadingPolicy *iwfidl.PersistenceLoadingPolicy | ||
| ExecuteApiSearchAttributesLoadingPolicy *iwfidl.PersistenceLoadingPolicy | ||
| SearchAttributesLoadingPolicy *iwfidl.PersistenceLoadingPolicy | ||
| WaitUntilApiDataAttributesLoadingPolicy *iwfidl.PersistenceLoadingPolicy | ||
| ExecuteApiDataAttributesLoadingPolicy *iwfidl.PersistenceLoadingPolicy |
There was a problem hiding this comment.
Similar to https://github.com/indeedeng/iwf-python-sdk/pull/37/files#r1805101514 we can sort them and add some comments to make it more friendly
iwf/state_options.go
Outdated
| ExecuteApiRetryPolicy *iwfidl.RetryPolicy | ||
| WaitUntilApiFailurePolicy *iwfidl.WaitUntilApiFailurePolicy | ||
| ExecuteApiFailureProceedState WorkflowState | ||
| WaitUntilApiSearchAttributesLoadingPolicy *iwfidl.PersistenceLoadingPolicy |
There was a problem hiding this comment.
The comments should be here, just lie Java docs
There was a problem hiding this comment.
Ah thanks! Didn't see this file at first. Done now ✅
longquanzheng
changed the title
longquanzheng
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating iwf-idl to latest to: Allow to use separate persistency loading policy for waitUntil
Depends on indeedeng/iwf#448
Closes indeedeng/iwf#387