IWF-105: Rename logevent > handleevent

indeedeng · Nov 18, 2024 · 78e3985 · 78e3985
1 parent 397e211
commit 78e3985
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 33 deletions.
diff --git a/service/common/handleevent/logevent.go b/service/common/handleevent/logevent.go
@@ -0,0 +1,16 @@
+package handleevent
+
+import "github.com/indeedeng/iwf/gen/iwfidl"
+
+// The implementation must be lightweight, reliable and fast (less than 1s)
+type HandleEventFunc func(event iwfidl.IwfEvent)
+
+var Handler HandleEventFunc = DefaultHandleEventFunc
+
+func SetHandleEventFunc(handler HandleEventFunc) {
+	Handler = handler
+}
+
+func DefaultHandleEventFunc(event iwfidl.IwfEvent) {
+	// Noop by default
+}
diff --git a/service/common/logevent/logevent.go b/service/common/logevent/logevent.go
diff --git a/service/interpreter/activityImpl.go b/service/interpreter/activityImpl.go
@@ -6,7 +6,7 @@ import (
 	"github.com/indeedeng/iwf/gen/iwfidl"
 	"github.com/indeedeng/iwf/service"
 	"github.com/indeedeng/iwf/service/common/compatibility"
-	"github.com/indeedeng/iwf/service/common/logevent"
+	"github.com/indeedeng/iwf/service/common/handleevent"
 	"github.com/indeedeng/iwf/service/common/ptr"
 	"github.com/indeedeng/iwf/service/common/rpc"
 	"github.com/indeedeng/iwf/service/common/urlautofix"
@@ -54,7 +54,7 @@ func StateApiWaitUntil(
 	resp, httpResp, err := req.WorkflowStateStartRequest(input.Request).Execute()
 	printDebugMsg(logger, err, iwfWorkerBaseUrl)
 	if checkHttpError(err, httpResp) {
-		logevent.Log(iwfidl.IwfEvent{
+		handleevent.Log(iwfidl.IwfEvent{
 			EventType:     iwfidl.STATE_WAIT_UNTIL_ATTEMPT_FAIL_EVENT,
 			WorkflowType:  input.Request.WorkflowType,
 			WorkflowId:    activityInfo.WorkflowExecution.ID,
@@ -66,7 +66,7 @@ func StateApiWaitUntil(
 	}
 
 	if err := checkCommandRequestFromWaitUntilResponse(resp); err != nil {
-		logevent.Log(iwfidl.IwfEvent{
+		handleevent.Log(iwfidl.IwfEvent{
 			EventType:     iwfidl.STATE_WAIT_UNTIL_ATTEMPT_FAIL_EVENT,
 			WorkflowType:  input.Request.WorkflowType,
 			WorkflowId:    activityInfo.WorkflowExecution.ID,
@@ -82,7 +82,7 @@ func StateApiWaitUntil(
 		resp.LocalActivityInput = composeInputForDebug(input.Request.Context.GetStateExecutionId())
 	}
 
-	logevent.Log(iwfidl.IwfEvent{
+	handleevent.Log(iwfidl.IwfEvent{
 		EventType:          iwfidl.STATE_WAIT_UNTIL_ATTEMPT_SUCC_EVENT,
 		WorkflowType:       input.Request.WorkflowType,
 		WorkflowId:         activityInfo.WorkflowExecution.ID,
@@ -133,7 +133,7 @@ func StateApiExecute(
 	resp, httpResp, err := req.WorkflowStateDecideRequest(input.Request).Execute()
 	printDebugMsg(logger, err, iwfWorkerBaseUrl)
 	if checkHttpError(err, httpResp) {
-		logevent.Log(iwfidl.IwfEvent{
+		handleevent.Log(iwfidl.IwfEvent{
 			EventType:        iwfidl.STATE_EXECUTE_ATTEMPT_FAIL_EVENT,
 			WorkflowType:     input.Request.WorkflowType,
 			WorkflowId:       activityInfo.WorkflowExecution.ID,
@@ -147,7 +147,7 @@ func StateApiExecute(
 	}
 
 	if err = checkStateDecisionFromResponse(resp); err != nil {
-		logevent.Log(iwfidl.IwfEvent{
+		handleevent.Log(iwfidl.IwfEvent{
 			EventType:        iwfidl.STATE_EXECUTE_ATTEMPT_FAIL_EVENT,
 			WorkflowType:     input.Request.WorkflowType,
 			WorkflowId:       activityInfo.WorkflowExecution.ID,
@@ -165,7 +165,7 @@ func StateApiExecute(
 		resp.LocalActivityInput = composeInputForDebug(input.Request.Context.GetStateExecutionId())
 	}
 
-	logevent.Log(iwfidl.IwfEvent{
+	handleevent.Log(iwfidl.IwfEvent{
 		EventType:          iwfidl.STATE_EXECUTE_ATTEMPT_SUCC_EVENT,
 		WorkflowType:       input.Request.WorkflowType,
 		WorkflowId:         activityInfo.WorkflowExecution.ID,

diff --git a/service/interpreter/workflowImpl.go b/service/interpreter/workflowImpl.go
@@ -4,7 +4,7 @@ import (
 	"context"
 	"fmt"
 	uclient "github.com/indeedeng/iwf/service/client"
-	"github.com/indeedeng/iwf/service/common/logevent"
+	"github.com/indeedeng/iwf/service/common/handleevent"
 	"github.com/indeedeng/iwf/service/common/ptr"
 	"github.com/indeedeng/iwf/service/common/utils"
 	"github.com/indeedeng/iwf/service/interpreter/env"
@@ -24,7 +24,7 @@ func InterpreterImpl(
 		if !provider.IsReplaying(ctx) {
 			// send metrics for the workflow result
 			if retErr == nil {
-				logevent.Log(iwfidl.IwfEvent{
+				handleevent.Log(iwfidl.IwfEvent{
 					EventType:          iwfidl.WORKFLOW_COMPLETE_EVENT,
 					WorkflowType:       input.IwfWorkflowType,
 					WorkflowId:         provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -33,7 +33,7 @@ func InterpreterImpl(
 					EndTimestampInMs:   ptr.Any(provider.Now(ctx).UnixMilli()),
 				})
 			} else if provider.IsApplicationError(retErr) {
-				logevent.Log(iwfidl.IwfEvent{
+				handleevent.Log(iwfidl.IwfEvent{
 					EventType:     iwfidl.WORKFLOW_FAIL_EVENT,
 					WorkflowType:  input.IwfWorkflowType,
 					WorkflowId:    provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -147,7 +147,7 @@ func InterpreterImpl(
 
 	if !input.IsResumeFromContinueAsNew {
 		if !provider.IsReplaying(ctx) {
-			logevent.Log(iwfidl.IwfEvent{
+			handleevent.Log(iwfidl.IwfEvent{
 				EventType:     iwfidl.WORKFLOW_START_EVENT,
 				WorkflowType:  input.IwfWorkflowType,
 				WorkflowId:    provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -561,7 +561,7 @@ func processStateExecution(
 		doLoadingPolicy := compatibility.GetWaitUntilApiDataObjectsLoadingPolicy(state.StateOptions)
 
 		if !provider.IsReplaying(ctx) {
-			logevent.Log(iwfidl.IwfEvent{
+			handleevent.Log(iwfidl.IwfEvent{
 				EventType:     iwfidl.STATE_WAIT_UNTIL_EE_START_EVENT,
 				WorkflowType:  basicInfo.IwfWorkflowType,
 				WorkflowId:    provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -583,14 +583,14 @@ func processStateExecution(
 			})
 		if !provider.IsReplaying(ctx) {
 			if errStartApi == nil {
-				logevent.Log(iwfidl.IwfEvent{
+				handleevent.Log(iwfidl.IwfEvent{
 					EventType:     iwfidl.STATE_WAIT_UNTIL_EE_FAIL_EVENT,
 					WorkflowType:  basicInfo.IwfWorkflowType,
 					WorkflowId:    provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
 					WorkflowRunId: provider.GetWorkflowInfo(ctx).WorkflowExecution.RunID,
 				})
 			} else {
-				logevent.Log(iwfidl.IwfEvent{
+				handleevent.Log(iwfidl.IwfEvent{
 					EventType:          iwfidl.STATE_WAIT_UNTIL_EE_COMPLETE_EVENT,
 					WorkflowType:       basicInfo.IwfWorkflowType,
 					WorkflowId:         provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -824,7 +824,7 @@ func invokeStateExecute(
 	var decideResponse *iwfidl.WorkflowStateDecideResponse
 
 	if !provider.IsReplaying(ctx) {
-		logevent.Log(iwfidl.IwfEvent{
+		handleevent.Log(iwfidl.IwfEvent{
 			EventType:        iwfidl.STATE_EXECUTE_EE_START_EVENT,
 			WorkflowType:     basicInfo.IwfWorkflowType,
 			WorkflowId:       provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -850,7 +850,7 @@ func invokeStateExecute(
 		})
 	if !provider.IsReplaying(ctx) {
 		if err == nil {
-			logevent.Log(iwfidl.IwfEvent{
+			handleevent.Log(iwfidl.IwfEvent{
 				EventType:          iwfidl.STATE_EXECUTE_EE_COMPLETE_EVENT,
 				WorkflowType:       basicInfo.IwfWorkflowType,
 				WorkflowId:         provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,
@@ -861,7 +861,7 @@ func invokeStateExecute(
 				EndTimestampInMs:   ptr.Any(provider.Now(ctx).UnixMilli()),
 			})
 		} else {
-			logevent.Log(iwfidl.IwfEvent{
+			handleevent.Log(iwfidl.IwfEvent{
 				EventType:        iwfidl.STATE_EXECUTE_EE_FAIL_EVENT,
 				WorkflowType:     basicInfo.IwfWorkflowType,
 				WorkflowId:       provider.GetWorkflowInfo(ctx).WorkflowExecution.ID,