improve wait workflow timeout

indeedeng · Feb 21, 2024 · d7cd2b1 · d7cd2b1
1 parent 4c5d4df
commit d7cd2b1
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/service/api/service.go b/service/api/service.go
@@ -154,6 +154,15 @@ func (s *serviceImpl) ApiV1WorkflowWaitForStateCompletion(
 	defer cancFunc()
 	var output service.WaitForStateCompletionWorkflowOutput
 	getErr := s.client.GetWorkflowResult(subCtx, &output, workflowId, runId)
+
+	if s.client.IsRequestTimeoutError(getErr) {
+		// the workflow is still running, but the wait has exceeded limit
+		return nil, errors.NewErrorAndStatus(
+			service.HttpStatusCodeSpecial4xxError1,
+			iwfidl.LONG_POLL_TIME_OUT_SUB_STATUS,
+			"waiting has exceeded timeout limit")
+	}
+
 	if getErr != nil {
 		return nil, s.handleError(getErr)
 	}