Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cadence pipeline checks not starting #431

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix Cadence pipeline checks not starting #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose/ci-cadence-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ services:
networks:
- testing-network
zookeeper:
image: wurstmeister/zookeeper:3.4.6
image: wurstmeister/zookeeper:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart!!

Copy link
Member Author

@samuel27m samuel27m Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I do notice that the latest version here was released 6 years ago

Should we start using the official zookeeper image instead? Is there a reason we're using the wurstmeister/zookeeper image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should!
Last time I spent a few minutes trying out but it didn’t work. I didn’t got time to. Investigate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cadence has upgraded their docker compose to use the official one. I think we should do that and also upgrade the cadence image to the 1.x release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #432

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason was that cadence was using that kafka image and I just followed it

ports:
- "2181:2181"
networks:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose/ci-cadence-temporal-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ services:
networks:
- testing-network
zookeeper:
image: wurstmeister/zookeeper:3.4.6
image: wurstmeister/zookeeper:latest
ports:
- "2181:2181"
networks:
Expand Down
2 changes: 1 addition & 1 deletion docker-compose/integ-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ services:
networks:
- testing-network
zookeeper:
image: wurstmeister/zookeeper:3.4.6
image: wurstmeister/zookeeper:latest
ports:
- "2181:2181"
networks:
Expand Down
Loading