Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iwf-401: update activity type name to find reset history eventID #515

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

ktrops
Copy link
Contributor

@ktrops ktrops commented Dec 10, 2024

Description

Checklist

  • Code compiles correctly
  • Tests for the changes have been added
  • All tests passing
  • This PR change is backwards-compatible
  • This PR CONTAINS a (planned) breaking change (it is not backwards compatible)

Related Issue

Closes #issue_number

@longquanzheng
Copy link
Contributor

PR title: "iwf-401: update activity type name" -> "iwf-401: update activity type name to find reset history eventID"

This title will become the commit message so it's better to make it as clear as possible

@longquanzheng
Copy link
Contributor

Also need to do it for Cadence

@ktrops ktrops force-pushed the jira/katiea/iwf-401 branch from 6edb944 to a40d0dc Compare December 10, 2024 02:40
@longquanzheng
Copy link
Contributor

Unless its too hard, I would recommend you to add a test.

I have added one here in the signal test: https://github.com/indeedeng/iwf/blob/main/integ/signal_test.go#L236

it reset to stateId/stateExecutionId but the state has waitUntil so it doesn't cover the case that you fixed. So you can just find a workflow state that doesn't have waitUntil and reset it, then wait for the workflow to complete.

@stevo89519
Copy link
Contributor

logic looks good

@longquanzheng
Copy link
Contributor

https://github.com/indeedeng/iwf/blob/main/integ/workflow/skipstart/routers.go

this is a test workflow that skip waitUntil(used to be called stateStart)

integ/reset_by_state_id_test.go Outdated Show resolved Hide resolved
integ/reset_by_state_id_test.go Outdated Show resolved Hide resolved
integ/reset_by_state_id_test.go Outdated Show resolved Hide resolved
integ/workflow/reset/routers.go Outdated Show resolved Hide resolved
integ/workflow/reset/routers.go Outdated Show resolved Hide resolved
integ/workflow/reset/routers.go Outdated Show resolved Hide resolved
integ/workflow/reset/routers.go Outdated Show resolved Hide resolved
iwf-idl Outdated Show resolved Hide resolved
@ktrops ktrops force-pushed the jira/katiea/iwf-401 branch from e27010f to b7e0cd0 Compare December 16, 2024 18:59
@ktrops ktrops changed the title iwf-401: update activity type name iwf-401: update activity type name to find reset history eventID Dec 16, 2024
@ktrops ktrops merged commit 36e5a27 into main Dec 18, 2024
8 checks passed
@ktrops ktrops deleted the jira/katiea/iwf-401 branch December 18, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants