-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iwf-401: update activity type name to find reset history eventID #515
Conversation
PR title: "iwf-401: update activity type name" -> "iwf-401: update activity type name to find reset history eventID" This title will become the commit message so it's better to make it as clear as possible |
Also need to do it for Cadence |
6edb944
to
a40d0dc
Compare
Unless its too hard, I would recommend you to add a test. I have added one here in the signal test: https://github.com/indeedeng/iwf/blob/main/integ/signal_test.go#L236 it reset to stateId/stateExecutionId but the state has |
logic looks good |
https://github.com/indeedeng/iwf/blob/main/integ/workflow/skipstart/routers.go this is a test workflow that skip waitUntil(used to be called stateStart) |
bb28e12
to
e27010f
Compare
e27010f
to
b7e0cd0
Compare
Description
Checklist
Related Issue
Closes #issue_number