Test the various heuristics of erase_indices
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a targeted test to make sure we cover all the heuristic edge cases in `erase_indices`, used by `drain` and other methods. I found a failure from `cargo mutants` where we still passed tests after `erase_indices_sweep` was replaced with an empty body. I was concerned because that function contains `unsafe` code, so we *really* need it tested. It turns out that we do *sometimes* hit that in `quickcheck` tests, but might miss that if we're randomly unlucky, so this PR adds a new test that will hit all the edge cases every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a targeted test to make sure we cover all the heuristic edge
cases in
erase_indices, used bydrainand other methods.I found a failure from
cargo mutantswhere we still passed tests aftererase_indices_sweepwas replaced with an empty body. I was concernedbecause that function contains
unsafecode, so we really need ittested. It turns out that we do sometimes hit that in
quickchecktests, but might miss that if we're randomly unlucky, so this PR adds a
new test that will hit all the edge cases every time.