Marcosertoli/development #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in future and added to plotters/ directory
Fixed mypy errors
…lling runs in one go
…o modify the abstract_operator?
… missing from DATATYPES.
…the information if it's not hampered with.
…, and elements & impurities now both tuples for consistency
|
Following changes to DATATYPES and AVAILABLE_QUANTITIES, changed Indica-native DataArray formatting and adapted Plasma class accordingly. |
|
@hakosaj @pixelifytica @michael-gemmell This cleans up a lot of things in the readers and clarifies what datatypes are expected of each quantity, as well as what units. There's more to be done on unit consistency, e.g. if units are read from database -> check that they are consistent with Indica requirements, but I think it's a good start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed AVAILABLE_QUANTITIES and DATATYPES to make it easier to understand what is required of the reader, to assign long_name and units to each quantity read, and to simplify the reading.
Abstract reader now stripped to the bones, but still requiring work:
Once st40reader has been refactored to extract all MDS functions, it can also be refactored to make it much clearer what is required when building a reader.