Jussi reader separation #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified comments to ASTRA (that anyway has to be fixed)
|
Fixed minor bugs in the mds-utils, solved linting. Ready to merge from my perspective, but eager to have @michael-gemmell have a look and a go with anything that's not currently in the testing suite. |
|
Organisational comment: should we save all the CONF files in a separate directory, e.g. indica/configurations/? |
…ectly called in st40reader.py.
… no other methods needed in st40reader.py.
marcosertoli
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit fails due to a very minor linting thing (how the config files are structured causes this).
Removed the duplicate and ran pre-commit, some other minor structure fixes too.
There is a server error: not sure if it is my environment or the structure is still off. Can you test this?
I think all strictly-MDS+ methods are now in the MDSutils. At least thats the case as far as I understand? YOu said there was still something, but I do not know what it is. All the methods that directly access MDS+ are in the utils, and the methods in readed call these utils methods. That is what the plan was no?