Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marcosertoli/development #316

Merged
merged 56 commits into from
Apr 4, 2024
Merged

Marcosertoli/development #316

merged 56 commits into from
Apr 4, 2024

Conversation

marcosertoli
Copy link
Contributor

Fixed issue with midplane mapping

marcosertoli and others added 30 commits May 16, 2023 16:32
@marcosertoli
New tests vs. modelling (SMM geometry still to be fixed)
6e638e1
@marcosertoli
XRCS wavelength correction
2f188cc
@marcosertoli
save_figure method
70d2c57
@marcosertoli
fixed plotting
8e6c86d
@marcosertoli
merging st40 back in
dbf6920
@marcosertoli
Merge branch 'st40' into marcosertoli/development
cc98ded
@marcosertoli
Fixed bug in equilibrium R, z boundaries method
ea784ee
@marcosertoli
Added units to plotting
c795e4f
@marcosertoli
Added name and units to DataArray attributes
52ea85a
@marcosertoli
Added name and units to DataArray attributes
6226d96
@marcosertoli
Temporary fix for CXFF location and direction index selection
fc6c081
@marcosertoli
Temporary reader for MHD odd_n and even_n
8f92b8f
@marcosertoli
New utility method to save figure
932977c
@marcosertoli
Modified plotting method of load_modelling_plasma --> to be generalis…
5b437b4 
…ed in future and added to plotters/ directory
@marcosertoli
Pre-commit reformatting
2ce564c
@marcosertoli
Moved plot parameter setting to dedicated method in utilities.py
61f1569
@marcosertoli
Moved plot parameter setting to dedicated method in utilities.py
1ebcdcc 
Fixed mypy errors
@marcosertoli
Revised default rcParams for plots
37e8cdb
@marcosertoli
Fixed default plotting
10c4cac
@marcosertoli
Corrected variable names
62a9d60
@marcosertoli
Added temporary fix to read MHD tor mode data
1205995
@marcosertoli
Added DataArray long_name and units and minor details for plotting
682f640
@marcosertoli
Refactored to enable reading, analysing and plotting of multiple mode…
c1fbbae 
…lling runs in one go
@marcosertoli
Transect transform was missing machine_dims in input
57f4d05
@marcosertoli
Merge branch 'st40' into marcosertoli/development
9af99a3
@marcosertoli
Merge branch 'main' into marcosertoli/development
5ea7d0d
@marcosertoli
Changed wavelength range for Zeff workflow using PI
f3130f3
@marcosertoli
Merge branch 'main' into marcosertoli/development
4dd1559
@marcosertoli
Implementation of new DATATYPES and UNITS - next step adapt methods t…
904b6d6 
…o use them
@marcosertoli
Added periodictable package to get element information
4e28bc5
marcosertoli and others added 26 commits March 26, 2024 21:32
@marcosertoli
Using utilities.get_element_info for ELEMENT information
f178260
@marcosertoli
Changed datatypes to long_name and units - propagated to available_qu…
f44d117 
…antities.py and everything related
@marcosertoli
Added skipna to time binning method
3a295ea
@marcosertoli
ADAS separately tested in adf11 and adf11 tests - global test not req…
434d1c1 
…uired
@marcosertoli
Deleted not-very-useful tests - question for the future: do we need t…
d6f9a78 
…o modify the abstract_operator?
@marcosertoli
Simple import test of available_quantities - throws an error if value…
55a2399 
… missing from DATATYPES.
@marcosertoli
Start implementation of new quantities from here
5242306
@marcosertoli
Deleted old lines_of_sight.py transform
558b79a
@marcosertoli
Changed variable "times" to "time" for consistency with other dimensions
3310204
@marcosertoli
Merge branch 'main' into marcosertoli/development
5f2e9f1
@marcosertoli
Removed provenance since it's not used at all - raw data will retain …
9dcb35a 
…the information if it's not hampered with.
@marcosertoli
New available quantities now only has the str identifier of what DATA…
054e95b 
…TYPE it is
@marcosertoli
Minor mods to datatypes for consistency
235298e
@marcosertoli
Deleted redundant and dangerous max_freq - raw data must be as read f…
f684324 
…rom database
@marcosertoli
Deleted redundant and dangerous max_freq - raw data must be as read f…
b8fd610 
…rom database
@marcosertoli
Adapted whole project to new AVAILABLE_QUANTITIES and DATATYPES
8ba0ab0
@marcosertoli
Element info returns also symbol; generalized dataarray methods
73c3746
@marcosertoli
Refactored code to adapt to new generalized dataarray formatting
e6cac05
@marcosertoli
Added pytest.ini to make sure path is found
eae981c
@marcosertoli
Changed variable ion_charges to ion_charge for consistency with other…
d1a65ca 
… coordinates
@marcosertoli
Major changes to Plasma class to use new dataarray methods, datatypes…
20d1224 
…, and elements & impurities now both tuples for consistency
@marcosertoli
Minor mod to NAMESPACE (think whether this is needed)
4eb33fa
@marcosertoli
Ran pre-commit
30aed9d
@marcosertoli
Bayesworkflow test failing in midplane_profiles - comment out swap_di…
cd0fc2c 
…ms comman
@marcosertoli
Fixed mapping to midplane: R_midplane & z_midplane generated in Plasm…
913b5c0 
…a on the same dim so interpolation works as expected.
@marcosertoli
Merge branch 'main' into marcosertoli/development
c961562
@michael-gemmell michael-gemmell merged commit 4b5c7ae into main Apr 4, 2024
2 checks passed
@marcosertoli marcosertoli deleted the marcosertoli/development branch June 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-gemmell michael-gemmell Awaiting requested review from michael-gemmell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcosertoli @michael-gemmell