Adding example runs for diagnostic models #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also fixed a bug in the example he-like crystal model that will now work if you want to use it |
marcosertoli
added a commit
that referenced
this pull request
Jul 3, 2024
* feat: first forays into updating Indica * feat: 3.11 compatibility * feat: passed precommit * fix: disabled mypy precommit due to system error * readme: edited readme * fix: ppts reader data ambiguity * Fixed README.md for installation guidelines and consequent .lock file * Fixed 3.11 DataArray.data in another few instances * Deleted print statement * Upgraded default object .pkl to new versions. * Deleted print statement * feat: updated poetry * feat: version fix * Marcosertoli/311 further dataarray harmonisation (#329) * Now consistent with new DataArray convention + assigning Indica-native attributes also to DataArray coordinates. * Modified all DataArray coordinate instances to new convention * Fixed bug in PPTS reader (#330) * fix: rebuilt poetry lock * Adding example runs for diagnostic models (#331) * Marcosertoli/fix equilibrium r shift (#333) * Upgraded python version in poetry dev dependencies & ipython * Previous implementation was returning rhos with NaNs as fill_value which was making inversion methods crash. * Github CI workflows now asking for python 3.11 * Update utilities.py BAsed on comment * Update abstractreader.py Removed extra prints --------- Co-authored-by: Marco Sertoli <[email protected]> Co-authored-by: marcosertoli <[email protected]>
michael-gemmell
pushed a commit
that referenced
this pull request
Jul 4, 2024
* feat: first forays into updating Indica * feat: 3.11 compatibility * feat: passed precommit * fix: disabled mypy precommit due to system error * readme: edited readme * fix: ppts reader data ambiguity * Fixed README.md for installation guidelines and consequent .lock file * Fixed 3.11 DataArray.data in another few instances * Deleted print statement * Upgraded default object .pkl to new versions. * Deleted print statement * feat: updated poetry * feat: version fix * Marcosertoli/311 further dataarray harmonisation (#329) * Now consistent with new DataArray convention + assigning Indica-native attributes also to DataArray coordinates. * Modified all DataArray coordinate instances to new convention * Fixed bug in PPTS reader (#330) * fix: rebuilt poetry lock * Adding example runs for diagnostic models (#331) * Upgraded python version in poetry dev dependencies & ipython * Previous implementation was returning rhos with NaNs as fill_value which was making inversion methods crash. * Github CI workflows now asking for python 3.11 * More R_shift fixing: (R,z) range of PSI and RHO must be restricted to where every time and radial points are != NaN * Fixed revision reading across all methods * Changed R_midplane -> R, rpos -> R, zpos -> z for consistency across Indica * Refactoring ASTRA available_quantities.py - reader also need reprocessing * Assigning PPTS z as additional coordinate to midplane fit * Fixed XRCS wavelength rescaling --------- Co-authored-by: Jussi Hakosalo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.