Marcosertoli/equilibrium not nan #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a into jussihakosalo/indica311
* Now consistent with new DataArray convention + assigning Indica-native attributes also to DataArray coordinates. * Modified all DataArray coordinate instances to new convention
…a into jussihakosalo/indica311
…ich was making inversion methods crash.
… where every time and radial points are != NaN
|
michael-gemmell
requested changes
Jul 4, 2024
indica/readers/st40reader.py
Outdated
| wavelength, _ = self._get_signal( | ||
| uid, instrument, ":wavelength", results["revision"] | ||
| ) | ||
| # TODO: change once wavelength in MDS+ has been fixed to nanometers! |
There was a problem hiding this comment.
Why has this been readded? New XRCS runs don't need this.
There was a problem hiding this comment.
Error: will check it out and fix. Send it back you you by EOP today
michael-gemmell
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.