init class attrs with mutable arrays not frozen

indirect · Dec 4, 2023 · bc4c801 · bc4c801
1 parent 935b0c3
commit bc4c801
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/rails-footnotes.rb b/lib/rails-footnotes.rb
@@ -7,8 +7,8 @@
 require 'rails-footnotes/extension'
 
 module Footnotes
-  thread_mattr_accessor :before_hooks, default: []
-  thread_mattr_accessor :after_hooks, default: []
+  thread_mattr_accessor :before_hooks
+  thread_mattr_accessor :after_hooks
   thread_mattr_accessor :enabled, default: false
 
   class << self
@@ -59,6 +59,9 @@ def self.setup
   end
 end
 
+Footnotes.before_hooks = []
+Footnotes.after_hooks = []
+
 ActiveSupport.on_load(:action_controller) do
   ActionController::Base.send(:include, Footnotes::RailsFootnotesExtension)
 end

diff --git a/lib/rails-footnotes/notes/log_note.rb b/lib/rails-footnotes/notes/log_note.rb
@@ -4,10 +4,11 @@ class LogNote < AbstractNote
 
       autoload :NoteLogger, 'rails-footnotes/notes/log_note/note_logger'
 
-      thread_cattr_accessor :logs, default: []
+      thread_cattr_accessor :logs
       thread_cattr_accessor :original_logger
 
       def self.start!(controller)
+        self.logs = []
         self.original_logger = Rails.logger
         note_logger = NoteLogger.new(self.logs)
         note_logger.level = self.original_logger.level