Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support aborting on cache miss #828

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

matthiasdiener
Copy link
Collaborator

@matthiasdiener matthiasdiener commented Feb 28, 2024

What do you think @inducer? This would not only make debugging cache misses easier, it could also be used to automate determinism tests (by setting LOOPY_ABORT_ON_CACHE_MISS to something trueish, and rerunning the test).

@matthiasdiener matthiasdiener self-assigned this Feb 28, 2024
@inducer
Copy link
Owner

inducer commented Feb 29, 2024

I'm not wildly opposed, but I feel that it's also easy to just hack a 1/0 into that code path when needed. And for automated determinism tests, there are probably simpler approaches than to ask the codegen cache.

Also, "abort on cache miss" sounds like it would include all caches, but this applies to only one of many caches in loopy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants