Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure there are no 0-sized arrays in test_slice #630

Closed
wants to merge 1 commit into from

Conversation

isuruf
Copy link
Collaborator

@isuruf isuruf commented Oct 7, 2022

No description provided.

@inducer
Copy link
Owner

inducer commented Oct 7, 2022

What exactly is causing issues for the Intel ICD here? Empty NDRanges? Zero-size allocations? Both of these are already handled specially...

@isuruf
Copy link
Collaborator Author

isuruf commented Oct 8, 2022

Multiplying a zero sized array by a scalar.

@inducer
Copy link
Owner

inducer commented Oct 8, 2022

Yeah... but what specifically about that is causing issues? Any idea?

@isuruf
Copy link
Collaborator Author

isuruf commented Oct 15, 2022

Looks like this error happens in apple implementation too as pointed out by @alexfikl in #616 (comment)

@alexfikl
Copy link
Contributor

Looks like this error happens in apple implementation too as pointed out by @alexfikl in #616 (comment)

Hasn't happened in the last 3 runs though, so not quite sure what to make of that. Is it intermittent on Intel as well?

@isuruf
Copy link
Collaborator Author

isuruf commented Oct 16, 2022

Yes, you need end = randrange(start, ary_len) == start for the error to occur.

@alexfikl
Copy link
Contributor

Yes, you need end = randrange(start, ary_len) == start for the error to occur.

Ah, thanks! Missed the random in that test.

@inducer
Copy link
Owner

inducer commented Oct 16, 2022

Thanks! Superseded by #638.

@inducer inducer closed this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants