Stokes/Elasticity using biharmonic/Laplace #162

isuruf · 2022-06-27T18:45:38Z

Point sumpy back to main

setup.py

alexfikl · 2022-08-04T11:29:10Z

@isuruf I've been using #29 for my stuff. Should I switch to this? Does it contain any fixes or is it just a clean squash on top of main?

isuruf · 2022-08-04T14:24:29Z

@alexfikl, this PR has only parts of #29 so that it is easier to review. I'm not sure if this PR has all the features that you need. Probably not.

inducer · 2022-08-08T21:16:21Z

pytential/symbolic/elasticity.py

@@ -0,0 +1,166 @@
+__copyright__ = "Copyright (C) 2021 Isuru Fernando"


I think it'd be good to have CalculusPatch tests to ensure that PDE rediual for Stokes and elasticity is zero.

Added a test to check the stokes PDE in a9931e5 and elasticity in bb31471

That's technically not testing the Stokes potential, it's testing pytential-computed derivatives thereof.

pytential/symbolic/pde/system_utils.py

alexfikl

Added a bunch of nitpicks to pytential.symbolic.stokes (mostly based on how I've been using the new stuff). Many are ignorable, so feel free!

The main thing that bothered me while going through it was the nu_sym everywhere. It feels like that should be handled in elasticity so the user never gets a chance to pass nu_sym=3 from the Stokes wrappers.

pytential/symbolic/stokes.py

isuruf · 2022-09-08T22:52:22Z

@inducer, @alexfikl, this is ready for another round of reviews.

alexfikl

Left a bunch more nitpicks in pde.system_utils this time around :D

This is looking very cool!

pytential/symbolic/elasticity.py

pytential/symbolic/pde/system_utils.py

pytential/symbolic/typing.py

test/test_stokes.py

inducer · 2022-09-12T17:54:22Z

pytential/symbolic/elasticity.py

@@ -0,0 +1,166 @@
+__copyright__ = "Copyright (C) 2021 Isuru Fernando"


That's technically not testing the Stokes potential, it's testing pytential-computed derivatives thereof.

pytential/symbolic/pde/system_utils.py

inducer · 2022-09-12T17:58:52Z

pytential/symbolic/elasticity.py

@@ -0,0 +1,166 @@
+__copyright__ = "Copyright (C) 2021 Isuru Fernando"


Pull the docs of this into like an "internals" chapter? internals.rst?

pytential/symbolic/pde/system_utils.py

pytential/utils.py

pytential/symbolic/mappers.py

pytential/symbolic/pde/system_utils.py

isuruf · 2022-11-23T19:00:01Z

This is ready for another round of reviews

alexfikl

Left a bunch of nitpicks while reading this again. I don't think any of them are stoppers of any sort, so go for it when you and @inducer are done! 🚀

Also, thanks for all this Stokes performance work! It's been immensely helpful in the past two-ish years!

pytential/utils.py

test/test_pde_system_utils.py

pytential/symbolic/elasticity.py

doc/symbolic.rst

pytential/symbolic/dof_desc.py

pytential/symbolic/elasticity.py

pytential/symbolic/stokes.py

pytential/utils.py

pytential/symbolic/pde/system_utils.py

pytential/utils.py

pytential/symbolic/elasticity.py

test/test_stokes.py

pytential/symbolic/pde/system_utils.py

inducer · 2022-12-20T20:56:12Z

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

isuruf · 2022-12-28T19:43:53Z

@inducer, ready for a review

Co-authored-by: Andreas Klöckner <[email protected]>

inducer reviewed Jun 27, 2022

View reviewed changes

setup.py Outdated Show resolved Hide resolved

isuruf force-pushed the stokes_biharmonic2 branch 4 times, most recently from 95a898d to acc5ae0 Compare June 27, 2022 21:26

inducer reviewed Aug 8, 2022

View reviewed changes

inducer reviewed Aug 22, 2022

View reviewed changes

alexfikl reviewed Aug 23, 2022

View reviewed changes

isuruf force-pushed the stokes_biharmonic2 branch from fec9eab to ee09dbd Compare September 5, 2022 22:10

alexfikl reviewed Sep 12, 2022

View reviewed changes

inducer reviewed Sep 12, 2022

View reviewed changes

isuruf force-pushed the stokes_biharmonic2 branch from 0f130b0 to 0dca616 Compare September 12, 2022 22:49

isuruf commented Sep 14, 2022

View reviewed changes

pytential/symbolic/mappers.py Outdated Show resolved Hide resolved

inducer reviewed Nov 21, 2022

View reviewed changes

pytential/symbolic/pde/system_utils.py Show resolved Hide resolved

inducer reviewed Nov 21, 2022

View reviewed changes

pytential/symbolic/pde/system_utils.py Show resolved Hide resolved

isuruf force-pushed the stokes_biharmonic2 branch 2 times, most recently from f7b661d to d34f787 Compare November 23, 2022 15:06

alexfikl approved these changes Nov 25, 2022

View reviewed changes

inducer reviewed Dec 5, 2022

View reviewed changes

inducer reviewed Dec 12, 2022

View reviewed changes

isuruf requested a review from inducer December 14, 2022 17:59

isuruf force-pushed the stokes_biharmonic2 branch from 748329d to ae1333c Compare December 19, 2022 18:26

inducer reviewed Dec 19, 2022

View reviewed changes

isuruf force-pushed the stokes_biharmonic2 branch from 681b73d to c4173e1 Compare December 20, 2022 03:48

isuruf and others added 29 commits January 9, 2025 16:22

fix bad merge

9a31f5a

Update warning message

dbc4d79

Co-authored-by: Andreas Klöckner <[email protected]>

explain -1, -1, -1 and 0, 0, 0

b72ec65

Co-authored-by: Andreas Klöckner <[email protected]>

operator -> wrapper

0e7b878

-1 with size dim

5ff255d

List -> Sequence

4559899

unit test for solve_from_lu

fd33333

import Sequence

b1c1f26

Fix applying extra_deriv_dirs

e66ed4f

add a test for errors

ccb8bc3

formatting: 2 blank lines

33a8f84

simplify matrix

1d589bb

Check using calculus patch as well

e9cd110

describe the math

0440885

mention column of ones in A

12ed6dc

fix typo

f889a9d

Fix misleading naming in test_stokes

1f641c9

Placate flake8-comprehensions

49af3fb

Placate flake8-comprehensions again

39aa388

fix typo

3d8cec7

fix mypy errors

954c5d5

improve docs for stokes and elasticity

6f598f6

tests: update test_elasticity_pde method names

994a977

qbx: allow scalar densities

40aa82a

fix ruff errors

1dc57c4

fix typos

f879dcf

fix new ruff issues

0023ae5

fix new ruff issues

4df76e4

feat: update to new pymbolic

d1db7f6

alexfikl force-pushed the stokes_biharmonic2 branch from 19415b4 to d1db7f6 Compare January 9, 2025 14:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stokes/Elasticity using biharmonic/Laplace #162

Stokes/Elasticity using biharmonic/Laplace #162

isuruf commented Jun 27, 2022 •

edited

Loading

alexfikl commented Aug 4, 2022

isuruf commented Aug 4, 2022

inducer Aug 8, 2022

isuruf Sep 8, 2022

inducer Sep 12, 2022

alexfikl left a comment

isuruf commented Sep 8, 2022

alexfikl left a comment

inducer Sep 12, 2022

inducer Sep 12, 2022

isuruf commented Nov 23, 2022

alexfikl left a comment •

edited

Loading

inducer commented Dec 20, 2022

isuruf commented Dec 28, 2022

		@@ -0,0 +1,166 @@
		__copyright__ = "Copyright (C) 2021 Isuru Fernando"

Stokes/Elasticity using biharmonic/Laplace #162

Are you sure you want to change the base?

Stokes/Elasticity using biharmonic/Laplace #162

Conversation

isuruf commented Jun 27, 2022 • edited Loading

alexfikl commented Aug 4, 2022

isuruf commented Aug 4, 2022

inducer Aug 8, 2022

Choose a reason for hiding this comment

isuruf Sep 8, 2022

Choose a reason for hiding this comment

inducer Sep 12, 2022

Choose a reason for hiding this comment

alexfikl left a comment

Choose a reason for hiding this comment

isuruf commented Sep 8, 2022

alexfikl left a comment

Choose a reason for hiding this comment

inducer Sep 12, 2022

Choose a reason for hiding this comment

inducer Sep 12, 2022

Choose a reason for hiding this comment

isuruf commented Nov 23, 2022

alexfikl left a comment • edited Loading

Choose a reason for hiding this comment

inducer commented Dec 20, 2022

isuruf commented Dec 28, 2022

isuruf commented Jun 27, 2022 •

edited

Loading

alexfikl left a comment •

edited

Loading