Skip to content

Commit

Permalink
StatisticVisualizerBase: Changed signalName parameter to be mandatory.
Browse files Browse the repository at this point in the history
  • Loading branch information
levy committed Feb 19, 2024
1 parent 298b492 commit 2d104a1
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/inet/visualizer/base/StatisticVisualizerBase.cc
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,11 @@ void StatisticVisualizerBase::initialize(int stage)
opacity = par("opacity");
placementHint = parsePlacement(par("placementHint"));
placementPriority = par("placementPriority");
if (displayStatistics)
if (displayStatistics) {
if (opp_isempty(signalName))
throw cRuntimeError("The signalName parameter must be not empty");
subscribe();
}
}
}

Expand All @@ -92,18 +95,15 @@ void StatisticVisualizerBase::handleParameterChange(const char *name)

void StatisticVisualizerBase::subscribe()
{
if (*signalName != '\0')
visualizationSubjectModule->subscribe(registerSignal(signalName), this);
visualizationSubjectModule->subscribe(registerSignal(signalName), this);
}

void StatisticVisualizerBase::unsubscribe()
{
// NOTE: lookup the module again because it may have been deleted first
auto visualizationSubjectModule = findModuleFromPar<cModule>(par("visualizationSubjectModule"), this);
if (visualizationSubjectModule != nullptr) {
if (*signalName != '\0')
visualizationSubjectModule->unsubscribe(registerSignal(signalName), this);
}
if (visualizationSubjectModule != nullptr)
visualizationSubjectModule->unsubscribe(registerSignal(signalName), this);
}

void StatisticVisualizerBase::addResultRecorder(cComponent *source, simsignal_t signal)
Expand Down

0 comments on commit 2d104a1

Please sign in to comment.