Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to spec.image on existing Infinispan CR have no effect #2145

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ryanemerson
Copy link
Contributor

@ryanemerson ryanemerson commented Sep 9, 2024

Fixes #1223

@ryanemerson ryanemerson changed the title Changes to spec.image now trigger upgrades. Fixes #1223 Updates to spec.image on existing Infinispan CR have no effect Sep 9, 2024
@Crumby
Copy link
Collaborator

Crumby commented Sep 9, 2024

@ryanemerson Have you tried going from a custom image back to a newer version (remove spec.image and use newer version)

@ryanemerson
Copy link
Contributor Author

Have you tried going from a custom image back to a newer version (remove spec.image and use newer version)

@Crumby Good catch. I updated the test to include this scenario and the initial fix didn't work. In order to handle this scenario, it was necessary to add an additional ".status.operand.customImage" field.

@ryanemerson ryanemerson merged commit c2fa34b into infinispan:main Sep 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing spec.image does not cause reconciling
2 participants