Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape timestamps for fields and tags #131

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

rubhanazeem
Copy link
Contributor

@rubhanazeem rubhanazeem commented Nov 13, 2023

Proposed Changes

Briefly describe your proposed changes: Timestamps present in fields and tags are not converted into integers. They should be converted. This PR handles that and converts timestamps from tags and fields into integers. This change is required for influxdb-rails 2.0.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • rake test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@rubhanazeem rubhanazeem changed the title Escape timestamps for fields and tags fix: escape timestamps for fields and tags Nov 13, 2023
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rubhanazeem,

Thank you for your PR! 👍

Could you please update the CHANGELOG.md with a brief description of your changes? Also, since this PR introduces some minor breaking changes, kindly update the major version of the client to 3.0.0 in lib/influxdb2/client/version.rb.

Thanks again for your contribution!

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also rebase your sources with the master branch. The master branch has an updated CI configuration with important fixes.

@rubhanazeem rubhanazeem force-pushed the escape-fields-timestamps branch 3 times, most recently from cb0b3c9 to 0a7fd14 Compare November 17, 2023 09:19
@rubhanazeem
Copy link
Contributor Author

Hi @bednar, I've updated the major version but it's not yet available on git that's why it's failing. Could you please have a look at this?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c13e5e1) 48.22% compared to head (6bc7ca4) 48.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   48.22%   48.25%   +0.03%     
==========================================
  Files          77       77              
  Lines        7946     7901      -45     
==========================================
- Hits         3832     3813      -19     
+ Misses       4114     4088      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bednar
Copy link
Contributor

bednar commented Nov 18, 2023

@rubhanazeem I will take a look, thanks again for your PR

@bednar bednar added this to the 2.10.0 milestone Nov 20, 2023
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit e2ca27d into influxdata:master Nov 20, 2023
16 of 17 checks passed
@rubhanazeem rubhanazeem deleted the escape-fields-timestamps branch November 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants