-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape timestamps for fields and tags #131
fix: escape timestamps for fields and tags #131
Conversation
ac58915
to
01f01ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rubhanazeem,
Thank you for your PR! 👍
Could you please update the CHANGELOG.md
with a brief description of your changes? Also, since this PR introduces some minor breaking changes, kindly update the major version of the client to 3.0.0
in lib/influxdb2/client/version.rb
.
Thanks again for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also rebase your sources with the master
branch. The master
branch has an updated CI
configuration with important fixes.
cb0b3c9
to
0a7fd14
Compare
0a7fd14
to
6fbd19b
Compare
Hi @bednar, I've updated the major version but it's not yet available on git that's why it's failing. Could you please have a look at this? |
6fbd19b
to
1ee23e9
Compare
1ee23e9
to
6bc7ca4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 48.22% 48.25% +0.03%
==========================================
Files 77 77
Lines 7946 7901 -45
==========================================
- Hits 3832 3813 -19
+ Misses 4114 4088 -26 ☔ View full report in Codecov by Sentry. |
@rubhanazeem I will take a look, thanks again for your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Proposed Changes
Briefly describe your proposed changes: Timestamps present in fields and tags are not converted into integers. They should be converted. This PR handles that and converts timestamps from tags and fields into integers. This change is required for influxdb-rails 2.0.
Checklist
rake test
completes successfully