docs(template): Document template too large #321
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRichardson
added
the
documentation
Changes: ErrorResponse for /api/v2/template/apply The following adds documentation about a new feature that issues an error message if the template is too large. Currently, this targets only cloud, but we should consider this for OSS. I'll open this up for discussion, if in doubt I'll move this to cloud only as a divergent API.
SimonRichardson
force-pushed
the
document-template-too-large
branch
from
e517592
to
6f5b71a
Compare
The following just ensures that we don't inline the reference for errors that have the same body but different error code. This is shame, but I can see why. The fix is simple, just create a new template reference that duplicates the TemplateSummaryError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The following adds documentation about a new feature that issues an
error message if the template is too large. Currently, this targets only
cloud, but we should consider this for OSS. I'll open this up for
discussion, if in doubt I'll move this to cloud only as a divergent API.