feat: support targeting the root of an object where source is a subtree; tests #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebond
commented
Jul 14, 2023
| @@ -185,26 +185,124 @@ fn apply_mappings( | |||
| debug!(%dbg, "before"); | |||
|
|
|||
| debug!(?subtree, ?mapping.to_field_path, "to field path"); | |||
| if mapping.to_field_path.starts_with("metadata.") { | |||
There was a problem hiding this comment.
this block is preserved, just moved down to the last match pattern
lukebond
commented
Jul 14, 2023
| Mapping { | ||
| from_field_path: Some(_), | ||
| to_field_path: None, | ||
| } => { |
There was a problem hiding this comment.
this block is the bulk of the change to be reviewed, and the supporting functions it calls
lukebond
commented
Jul 14, 2023
mkmik
reviewed
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34
this PR also improves the tests by adding controller test cases for all the types of ResourceSyncs that we use this project for, including this new type that is now supported.
previously, only the
from_field_pathfield of theMappingwas optional, so you could copy an entire resource into a target subtree but you couldn't copy a source subtree into the root of a target resource.in a previous PR i thought i was implementing this by allowing an empty string as the mapping's target path, however there were two things wrong with that:
this is a dependency for https://github.com/influxdata/tubernetes/issues/752