Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(inputs.sql): Add protocol to DSN #16330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midlan
Copy link

@midlan midlan commented Dec 18, 2024

Summary

For some reason telegraf was not working for sql input until i added tcp(...) parenthesis to dsn.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@srebhan
Copy link
Member

srebhan commented Dec 18, 2024

@midlan thanks for your contribution! Please sign the CLA so we can start reviewing your PR!

@srebhan srebhan self-assigned this Dec 18, 2024
@srebhan
Copy link
Member

srebhan commented Dec 19, 2024

!signed-cla

1 similar comment
@midlan
Copy link
Author

midlan commented Dec 19, 2024

!signed-cla

@srebhan srebhan changed the title README sql input config dsn fix docs(inputs.sql): Add protocol to DSN Dec 20, 2024
@telegraf-tiger telegraf-tiger bot added area/sql docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 20, 2024
@srebhan
Copy link
Member

srebhan commented Dec 20, 2024

@midlan you need to also make this change to sample.conf (and run make docs) as we enforce both README.md and sample.conf to be in sync... Otherwise the change looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql docs Issues related to Telegraf documentation and configuration descriptions plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants