Skip to content

Commit

Permalink
feat(ui): change boolean variable names
Browse files Browse the repository at this point in the history
  • Loading branch information
mavarius committed Oct 18, 2023
1 parent 4a9d79c commit 65ec08a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/billing/components/PayAsYouGo/PayAsYouGo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {selectCurrentIdentity} from 'src/identity/selectors'

const BillingPayAsYouGo: FC = () => {
const {account} = useSelector(selectCurrentIdentity)
const directSignup = account.billingProvider === 'zuora'
const isdDirectSignup = account.billingProvider === 'zuora'

return (
<FlexBox
Expand All @@ -36,7 +36,7 @@ const BillingPayAsYouGo: FC = () => {
>
<BillingInfoWrapper>
<>
{directSignup && <PricingAlert />}
{isdDirectSignup && <PricingAlert />}
<PlanTypePanel />
<Panel>
<Panel.Header testID="past-invoices--header">
Expand Down
8 changes: 4 additions & 4 deletions src/homepageExperience/ClickThroughAnnouncementHandler.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ export const ClickThroughAnnouncementHandler: FC = () => {
useEffect(() => {
// Current Announcement: PAYG Pricing Increase
// Audience: Cloud, Pay As You Go, Direct Signups
const paygAccount = account.type === 'pay_as_you_go'
const directSignup = account.billingProvider === 'zuora'
const audience = CLOUD && paygAccount && directSignup
const isPaygAccount = account.type === 'pay_as_you_go'
const isDirectSignup = account.billingProvider === 'zuora'
const isTargetAudience = CLOUD && isPaygAccount && isDirectSignup

if (audience) {
if (isTargetAudience) {
setCurrentAnnouncement('payg-pricing-increase-announcement')

if (announcementState['display']) {
Expand Down

0 comments on commit 65ec08a

Please sign in to comment.