Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(influxql): add e2e tests #6739

Merged
merged 12 commits into from
Jun 27, 2023
Merged

Conversation

appletreeisyellow
Copy link
Contributor

Closes #6726

This PR adds end-to-end tests for InfluxQL, including features of schema composition, query execution, save/load, and csv download.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@appletreeisyellow appletreeisyellow requested a review from a team as a code owner June 20, 2023 22:56
@@ -196,7 +196,7 @@ const ScriptQueryBuilder: FC = () => {
)

const tsmNewScriptDropDown =
isFlagEnabled('influxqlUI') && hasDBRPs() ? (
isFlagEnabled('influxqlUI') && hasDBRPs() && CLOUD ? (
Copy link
Contributor Author

@appletreeisyellow appletreeisyellow Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to the e2e test, I realized InfluxQL should be only available in cloud, and not in v2 OSS. Confirmed with Gary on slack

Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 22, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 22, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 22, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2023
@appletreeisyellow appletreeisyellow added this pull request to the merge queue Jun 27, 2023
Merged via the queue into master with commit efeb0af Jun 27, 2023
@appletreeisyellow appletreeisyellow deleted the chunchun/influxql-e2e-test branch June 27, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxQL UI: Add e2e tests
2 participants