-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(client_libs): update Node.js wizard to use new v3 client #6762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes:
-
These instructions are currently using the old example which writes 5 points in a loop. Please update it to use the new, more useful "insect census" example. This can be found in the other new guides like for Go, Python.
-
In the Client Libraries section of the Load Data page, update the card with the
write | query
tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Write Data & Query Data sections please use the "insect census" example used in the Go, Python, & C# guides (the insect data example). These are more useful and comprehensive than the older "write 5 points in a loop" example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is changed to "insect census".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the newer "Insect Census" example as shown in the Go, Python, and C# wizards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example is changed to "insect census".
src/homepageExperience/components/steps/nodejs/ExecuteQuerySql.tsx
Outdated
Show resolved
Hide resolved
src/homepageExperience/components/steps/nodejs/InstallDependenciesSql.tsx
Outdated
Show resolved
Hide resolved
src/homepageExperience/components/steps/nodejs/ExecuteQuerySql.tsx
Outdated
Show resolved
Hide resolved
src/homepageExperience/components/steps/nodejs/ExecuteQuerySql.tsx
Outdated
Show resolved
Hide resolved
src/homepageExperience/components/steps/nodejs/WriteDataSql.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Campbell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
@mavarius thanks for your review |
Node.js
wizard to use new https://github.com/bonitoo-io/influxdb3-js forioxOnboarding
Checklist
Authors and Reviewer(s), please verify the following: