chore: remove feature flag influxqlUI
#6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdoconnell
previously approved these changes
Sep 25, 2023
| @@ -111,7 +112,10 @@ const SaveAsScript: FC<Props> = ({language, onClose, setOverlayType, type}) => { | |||
| setResult(null) | |||
| clearViewOptions() | |||
|
|
|||
| if (isIoxOrg || isFlagEnabled('influxqlUI')) { | |||
| // InfluxQL works on both IOx and TSM, so if an account has | |||
There was a problem hiding this comment.
This will also work in OSS, correct? The only different thing I could think of doing differently here is if we need a CLOUD check.
There was a problem hiding this comment.
InfluxQL will not show up in OSS because of this line, so OSS users will never need to save an InfluxQL script, so no need CLOUD here 👍
wdoconnell
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6800
The feature flag
influxqlUIhas been on in production for two weeks without any issues, so removing it in this PRChecklist
Authors and Reviewer(s), please verify the following: