Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error notifications in annotations and notebooks (cherry-pick) #6953

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

philjb
Copy link
Contributor

@philjb philjb commented Sep 20, 2024

This is a cherry-pick of pr #6927 and commit 71f8c45

I noticed that annotations and notebooks could display the api error
when requests fail - they are not consistent about it.

  • fix: improve failure error message notifications

Including the underlying error in error messages, this improves
notebooks, dashboards, labels, and annotations. Many other error
notifications all need improving e.g. in tasks and secrets.

* chore: improve error notifications in annotations and notebooks

I noticed that annotations and notebooks could display the api error
when requests fail - they are not consistent about it.

* fix: improve failure error message notifications

Including the underlying error in error messages, this improves
notebooks, dashboards, labels, and annotations. Many other error
notifications all need improving e.g. in tasks and secrets.

* chore: run yarn prettier:fix

* chore: whitespace to trigger ci
@philjb philjb requested a review from a team as a code owner September 20, 2024 04:05
@philjb philjb changed the title chore: improve error notifications in annotations and notebooks chore: improve error notifications in annotations and notebooks (cherry-pick) Sep 20, 2024
Copy link

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philjb philjb merged commit 7de3c96 into release/OSS Sep 20, 2024
5 of 6 checks passed
@philjb philjb deleted the pjb/error-msg-cherry-pick branch September 20, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants