Skip to content

Commit

Permalink
Merge pull request #2808 from infor-design/fix-percy-commands
Browse files Browse the repository at this point in the history
Chore: Update tests and specs for Percy commands
  • Loading branch information
tmcconechy authored Sep 9, 2024
2 parents 850259e + 6053690 commit 6e2e9f7
Show file tree
Hide file tree
Showing 9 changed files with 3,695 additions and 2,568 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: szenius/[email protected]
with:
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
NODE_OPTIONS: "--max-old-space-size=8192"

- name: Run Tests (percy)
run: npx percy exec -- npx playwright test --grep "percy"
run: npm run test:percy:ci
env:
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
NODE_OPTIONS: "--max-old-space-size=8192"
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: szenius/[email protected]
with:
Expand Down Expand Up @@ -48,20 +48,20 @@ jobs:
- name: Install Browsers
run: npx playwright install --with-deps

- name: Run Tests with Coverage
run: npm run test:coverage:ci
env:
NODE_OPTIONS: "--max-old-space-size=8192"

- name: Build again
run: npm run build

- name: Run Percy Tests
run: npx percy exec -- npx playwright test --grep "percy"
run: npm run test:percy:ci
env:
NODE_OPTIONS: "--max-old-space-size=8192"
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}

- name: Run Tests with Coverage
run: npm run test:coverage:ci
env:
NODE_OPTIONS: "--max-old-space-size=8192"

- name: Coveralls
uses: coverallsapp/github-action@master
with:
Expand Down
1 change: 1 addition & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"use"
]
}],
"scss/at-import-partial-extension": null,
"max-nesting-depth": [4, {
"ignore": ["pseudo-classes"],
"ignoreAtRules": [
Expand Down
1 change: 0 additions & 1 deletion doc/TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ You may want to run the test commands in a few ways depending what your doing. S
- `npm run test` Silences percy and runs playwright tests, can add `-- component` to this
- `npx nyc report` Make a readable coverage report
- `open coverage/index.html` Open the coverage report
- `npm run test:ci` Command that the `ci` (github actions) runs, shows more log and different report
- `npx playwright test --update-snapshots` Update snapshots for all tests and
- `npx playwright test --ui` Run the playwright GUI tool, most things in here are also in the Visual studio code plugin

Expand Down
Loading

0 comments on commit 6e2e9f7

Please sign in to comment.