Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2727 - ids dropdown dynamic value attribute #2764

Merged
merged 17 commits into from
Sep 9, 2024
Merged

2727 - ids dropdown dynamic value attribute #2764

merged 17 commits into from
Sep 9, 2024

Conversation

clayinfor
Copy link
Collaborator

@clayinfor clayinfor commented Aug 27, 2024 •
edited
Loading

Explain the details for making this change. What existing problem does the pull request solve?

Fixed IdsDropdown default value. There was a bug where the value property was not working properly with dynamic data.

Related github/jira issue (required):

Closes #2727

Steps necessary to review your pull request (required):

  1. Check out this branch and run: nvm i && nvm use && npm i && npm run start
  2. Ensure no regressions here: http://localhost:4300/ids-dropdown/dynamic-presentation.html
  3. In another terminal window, and run npm run publish:link
  4. Then check out this PR: 2727 - ids-dropdown dynamic value attribute enterprise-wc-examples#92
  5. Then run: npm i && npm link ids-enterprise-wc
  6. Then run: rm -fr .angular/cache && nvm i && nvm use && npm run build && npm run start
  7. Then confirm the dropdown shows "Product 3" by default here: http://localhost:4200/ids-dropdown/dynamic
  8. Also ensure no regressions here: http://localhost:4300/ids-dropdown/example.html

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@clayinfor clayinfor requested a review from a team as a code owner August 27, 2024 13:41
@clayinfor
Merge remote-tracking branch 'origin/main' into 2727-ids-dropdown-val…
4bb6cf0 
…ue-attribute

Fix broken links in doc/CHANGELOG.md
Conflicts: doc/CHANGELOG.md
@clayinfor clayinfor mentioned this pull request Aug 27, 2024
Closed
@tmcconechy
Copy link
Member

@clayinfor looks ok to me. Have a look at the tests though?

@clayinfor clayinfor force-pushed the 2727-ids-dropdown-value-attribute branch from 2ae5d1a to 068e675 Compare August 27, 2024 18:26
@clayinfor clayinfor force-pushed the 2727-ids-dropdown-value-attribute branch from 3f976d1 to f7caec2 Compare August 28, 2024 12:52
@tmcconechy tmcconechy added the status: wip 🚧 Work in Progress (Ignore for now) label Sep 4, 2024
@tmcconechy tmcconechy removed the status: wip 🚧 Work in Progress (Ignore for now) label Sep 6, 2024
tmcconechy
tmcconechy previously approved these changes Sep 6, 2024
View reviewed changes
n-ace-ancog
n-ace-ancog previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end.

Screen.Recording.2024-09-09.at.1.33.38.PM.mov

@tmcconechy tmcconechy merged commit 850259e into main Sep 9, 2024
2 checks passed
@tmcconechy tmcconechy deleted the 2727-ids-dropdown-value-attribute branch September 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmcconechy tmcconechy tmcconechy left review comments

@n-ace-ancog n-ace-ancog n-ace-ancog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IdsDropdown: Value property not working with dynamic data
3 participants
@clayinfor @tmcconechy @n-ace-ancog