Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2747 - Fix opened menus on navigation #2795

Merged
merged 1 commit into from
Sep 6, 2024
Merged

2747 - Fix opened menus on navigation #2795

merged 1 commit into from
Sep 6, 2024

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Sep 4, 2024

Explain the details for making this change. What existing problem does the pull request solve?

In a very specific app scenario, navigating the page causes click events to be established too early. Makes menus appear open when they should not be.

Related github/jira issue (required):
Fixes #2747

** Example Project**
stackblitz-starters-mhnb1p.zip

Steps necessary to review your pull request (required):

  • pull the branch and run npm run build:dist
  • unzip the attached project and put it in a folder
  • cd to that folder and run npm i
  • then take the files from the folder in build/dist/development and copy them over node_modules/ids-enterprise-wc in the zipped project
  • then run the zipped project by opening that folder in a terminal and running npm run start
  • in the sample app open the app menu and select a menu item and repeat this step
  • no menus should be open from navigating the menu (but the menu button will still work when clicked)

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner September 4, 2024 16:37
@n-ace-ancog
Copy link
Contributor

@tmcconechy can we have a page where we can test this? I don't see as well the zipped project mentioned.

@tmcconechy
Copy link
Member Author

@n-ace-ancog sorry i forgot the file. It is attached now. I wasnt able to reproduce it any other way than the example attached.

Copy link
Contributor

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end.

Baseline:

Screen.Recording.2024-09-06.at.6.14.29.PM.mov

Branch:

Screen.Recording.2024-09-06.at.6.15.42.PM.mov

Copy link
Collaborator

@ericangeles ericangeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tmcconechy tmcconechy merged commit c1d6264 into main Sep 6, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 2747-menus-open branch September 6, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsMenuButton: All menus are initially open
3 participants