Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2793 - Add validation indicator to IdsTab #2801

Merged
merged 9 commits into from
Sep 12, 2024
Merged

2793 - Add validation indicator to IdsTab #2801

merged 9 commits into from
Sep 12, 2024

Commits on Sep 12, 2024

  1. Add validation indicator to IdsTab

    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    921f712 View commit details
    Browse the repository at this point in the history

  2. Refactor tabs validation 

    - Add types to IdsValidationMixin & events
- Use `has-error` instead of `validation-has-error`
- Add method to IdsTabs for listing tabs, rather than querySelector from the outside.
    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e3fd932 View commit details
    Browse the repository at this point in the history

  3. Add more test cases for tabs

    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    dd55707 View commit details
    Browse the repository at this point in the history

  4. Only check IdsValidationMixin elements for validity, rather than all … 

    …elements that have a 'validate' attribute
    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3509e7b View commit details
    Browse the repository at this point in the history

  5. Add slot for tab error to allow cusomizing or hiding it

    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4bdb2a9 View commit details
    Browse the repository at this point in the history

  6. Add missing imports to tab component

    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2367a1b View commit details
    Browse the repository at this point in the history

  7. Vertically align tab text with icons 

    Use flex gap instead of inline padding to pad trigger button & error icon
    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    867c9b2 View commit details
    Browse the repository at this point in the history

  8. Document Tab validation error in changelog

    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    cf0668c View commit details
    Browse the repository at this point in the history

  9. Revert validation optimization 

    checkValidation should always fire the "validate" event, similar to how the native checkValidity always fires an "invalid" event.
    @anhallbe
    anhallbe committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    bd8edc9 View commit details
    Browse the repository at this point in the history