Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update tests and specs for Percy commands #2808

Merged
merged 1 commit into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: szenius/[email protected]
with:
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
NODE_OPTIONS: "--max-old-space-size=8192"

- name: Run Tests (percy)
run: npx percy exec -- npx playwright test --grep "percy"
run: npm run test:percy:ci
env:
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
NODE_OPTIONS: "--max-old-space-size=8192"
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: szenius/[email protected]
with:
Expand Down Expand Up @@ -48,20 +48,20 @@ jobs:
- name: Install Browsers
run: npx playwright install --with-deps

- name: Run Tests with Coverage
run: npm run test:coverage:ci
env:
NODE_OPTIONS: "--max-old-space-size=8192"

- name: Build again
run: npm run build

- name: Run Percy Tests
run: npx percy exec -- npx playwright test --grep "percy"
run: npm run test:percy:ci
env:
NODE_OPTIONS: "--max-old-space-size=8192"
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}

- name: Run Tests with Coverage
run: npm run test:coverage:ci
env:
NODE_OPTIONS: "--max-old-space-size=8192"

- name: Coveralls
uses: coverallsapp/github-action@master
with:
Expand Down
1 change: 1 addition & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"use"
]
}],
"scss/at-import-partial-extension": null,
"max-nesting-depth": [4, {
"ignore": ["pseudo-classes"],
"ignoreAtRules": [
Expand Down
1 change: 0 additions & 1 deletion doc/TESTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ You may want to run the test commands in a few ways depending what your doing. S
- `npm run test` Silences percy and runs playwright tests, can add `-- component` to this
- `npx nyc report` Make a readable coverage report
- `open coverage/index.html` Open the coverage report
- `npm run test:ci` Command that the `ci` (github actions) runs, shows more log and different report
- `npx playwright test --update-snapshots` Update snapshots for all tests and
- `npx playwright test --ui` Run the playwright GUI tool, most things in here are also in the Visual studio code plugin

Expand Down
Loading
Loading