Skip to content

Commit

Permalink
Merge branch 'main' into 8943-autocomplete-key-down
Browse files Browse the repository at this point in the history
  • Loading branch information
tmcconechy authored Aug 29, 2024
2 parents d6c35bb + 31c330d commit 9023c2b
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 2 deletions.
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
## v4.99.0 Fixes

- `[Autocomplete]` Fixed a bug where autocomplete items are not shown when press key down. ([#8943](https://github.com/infor-design/enterprise-/issues/8943))
- `[ContextualToolbar]` Fixed datagrid hover color for contextual toolbar when a row is selected. ([#8980](https://github.com/infor-design/enterprise-/issues/8980))
- `[Datagrid]` Fixed a bug in compact mode where datagrid filters doesn't extend all throughout the parents width. ([#8900](https://github.com/infor-design/enterprise-/issues/8900))
- `[Datagrid]` Fixed data return by select event on datagrid when having filter on. ([#8905](https://github.com/infor-design/enterprise/issues/8905))
- `[Datagrid]` Optimize the initial loading of datagrids with filterable setting. ([#8935](https://github.com/infor-design/enterprise/issues/8935))
Expand Down
2 changes: 1 addition & 1 deletion src/components/button/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ a.btn-close {
overflow: hidden;

&:hover:not([disabled]):not(.btn-primary):not(.btn-secondary) {
background-color: $button-color-tertiary-hover-background-new !important;
background-color: $button-color-tertiary-hover-background-new;
color: $button-color-tertiary-hover-text;

.icon {
Expand Down
2 changes: 1 addition & 1 deletion src/components/toolbar/_toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ $toolbar-buttonset-height: 40px;
}

&:hover {
color: $contextual-toolbar-button-hover-color;
color: $contextual-toolbar-button-hover-color !important;
background-color: rgba(0, 0, 0, .3) !important;

.icon {
Expand Down
26 changes: 26 additions & 0 deletions tests/datagrid/datagrid.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,30 @@ test.describe('Datagrid tests', () => {
});
});
});

test.describe('datagrid toolbar button tests', () => {
const url = '/components/datagrid/example-mixed-selection.html';

test.beforeEach(async ({ page }) => {
await page.goto(url);
});

test.describe('button hover tests', () => {
test('value should have a proper color', async ({ page }) => {
await page.evaluate('document.getElementsByClassName("datagrid-selection-checkbox")[0].click()');

await expect(page.locator('.contextual-toolbar > .buttonset > .btn')).toBeVisible();

const button = page.locator('.contextual-toolbar > .buttonset > .btn');
await button.hover();

// eslint-disable-next-line arrow-body-style
const color = await button.evaluate((el) => {
return window.getComputedStyle(el).getPropertyValue('background-color');
});

await expect(color).toBe('rgba(0, 0, 0, 0.3)');
});
});
});
});

0 comments on commit 9023c2b

Please sign in to comment.